Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android dev #58

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Android dev #58

merged 1 commit into from
Aug 26, 2021

Conversation

BastiaanOlij
Copy link
Member

@BastiaanOlij BastiaanOlij commented Aug 4, 2021

For Android/Quest development, raise PRs against the android-dev branch.

Outstanding todos:

  • Fix color issue
  • Fix controller tracking

This PR is to merge it all into master once we're done.

@BastiaanOlij BastiaanOlij added the enhancement New feature or request label Aug 4, 2021
@BastiaanOlij BastiaanOlij added this to the 1.0.3 milestone Aug 4, 2021
@BastiaanOlij BastiaanOlij self-assigned this Aug 4, 2021
@BastiaanOlij BastiaanOlij modified the milestones: 1.0.3, 1.1.0 Aug 13, 2021
@BastiaanOlij BastiaanOlij force-pushed the android-dev branch 5 times, most recently from d64d9c0 to 7fff500 Compare August 19, 2021 12:32
@BastiaanOlij BastiaanOlij marked this pull request as ready for review August 23, 2021 13:24
@BastiaanOlij
Copy link
Member Author

@ChristophHaag @m4gr3d The only thing not working at the moment is finger tracking but we can live without that for now.
It also requires godotengine/godot#51780 to get the correct colors but that has now been approved and will likely be merged.

That does mean we can't release 1.1.0 until Godot 3.4 is out but that will happen soon after Akien returns from holidays.

I suggest we merge this branch into master. I've created a 1.0.x branch for the current version so we can apply patches for fixes to maintain support for Godot 3.3

Let me know what you guys think. I'm planning to start work on the proper Godot 4 port later in the week now that most of the GD extension logic has been merged (the replacement for the old GDNative layer).

@m4gr3d
Copy link
Collaborator

m4gr3d commented Aug 23, 2021

Merging into master sounds good!
Is there an issue that tracks the hand tracking bug?
Also, can you give push/write access to the repo.

@BastiaanOlij BastiaanOlij merged commit 978d76b into master Aug 26, 2021
@BastiaanOlij BastiaanOlij deleted the android-dev branch August 26, 2021 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android/Quest screen too bright Android/Quest Handtracking doesn't work
2 participants