Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Godot 4] Storage paths can now have space characters #388

Merged

Conversation

Vitorgus
Copy link
Contributor

Same as #387, but for the 4.0 branch.

I was trying to create a new file in the Firebase Storage with space characters in the file name, e.g:

Firebase.Storage.ref("path with space/image.png").put_file("res://image.png")

But it would fail, even if Firebase allows paths to have spaces. Turns out it was because the space character wasn't being encoded in the url parameter, only the forward slash / was.

Using the uri_encode(), it should encode both the slash and space characters, as well as any other character.

Copy link
Collaborator

@WolfgangSenff WolfgangSenff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you so much!

@WolfgangSenff WolfgangSenff merged commit b8e9328 into GodotNuts:4.x Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants