Skip to content

Commit

Permalink
deployment/docker: update Go builder from Go1.21.1 to Go1.21.3
Browse files Browse the repository at this point in the history
  • Loading branch information
valyala committed Oct 12, 2023
1 parent 31f7ef0 commit d984598
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/check-licenses.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@main
with:
go-version: 1.21.1
go-version: 1.21.3
id: go
- name: Code checkout
uses: actions/checkout@master
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v4
with:
go-version: 1.21.1
go-version: 1.21.3
check-latest: true
cache: true
if: ${{ matrix.language == 'go' }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v4
with:
go-version: 1.21.1
go-version: 1.21.3
check-latest: true
cache: true

Expand All @@ -56,7 +56,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v4
with:
go-version: 1.21.1
go-version: 1.21.3
check-latest: true
cache: true

Expand All @@ -81,7 +81,7 @@ jobs:
id: go
uses: actions/setup-go@v4
with:
go-version: 1.21.1
go-version: 1.21.3
check-latest: true
cache: true

Expand Down
2 changes: 1 addition & 1 deletion app/vmui/Dockerfile-web
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.21.1 as build-web-stage
FROM golang:1.21.3 as build-web-stage
COPY build /build

WORKDIR /build
Expand Down
2 changes: 1 addition & 1 deletion deployment/docker/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ DOCKER_NAMESPACE ?= victoriametrics
ROOT_IMAGE ?= alpine:3.18.4
CERTS_IMAGE := alpine:3.18.4

GO_BUILDER_IMAGE := golang:1.21.1-alpine
GO_BUILDER_IMAGE := golang:1.21.3-alpine
BUILDER_IMAGE := local/builder:2.0.0-$(shell echo $(GO_BUILDER_IMAGE) | tr :/ __)-1
BASE_IMAGE := local/base:1.1.4-$(shell echo $(ROOT_IMAGE) | tr :/ __)-$(shell echo $(CERTS_IMAGE) | tr :/ __)
DOCKER_BUILD ?= docker build
Expand Down
2 changes: 2 additions & 0 deletions docs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ The sandbox cluster installation is running under the constant load generated by

**vmalert's cmd-line flag `datasource.queryTimeAlignment` was deprecated and will have no effect anymore. It will be completely removed in next releases. See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5049) and more detailed changes below.**

* SECURITY: upgrade Go builder from Go1.21.1 to Go1.21.3. See [the list of issues addressed in Go1.21.2](https://github.com/golang/go/issues?q=milestone%3AGo1.21.2+label%3ACherryPickApproved) and [the list of issues addressed in Go1.21.3](https://github.com/golang/go/issues?q=milestone%3AGo1.21.3+label%3ACherryPickApproved).

* FEATURE: [vmalert](https://docs.victoriametrics.com/vmalert.html): add `eval_alignment` attribute for [Groups](https://docs.victoriametrics.com/vmalert.html#groups), it will align group query requests timestamp with interval like `datasource.queryTimeAlignment` did.
This also means that `datasource.queryTimeAlignment` command-line flag becomes deprecated now and will have no effect if configured. If `datasource.queryTimeAlignment` was set to `false` before, then `eval_alignment` has to be set to `false` explicitly under group.
See [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5049).
Expand Down
2 changes: 1 addition & 1 deletion snap/local/Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
GO_VERSION ?=1.21.1
GO_VERSION ?=1.21.3
SNAP_BUILDER_IMAGE := local/snap-builder:2.0.0-$(shell echo $(GO_VERSION) | tr :/ __)


Expand Down

0 comments on commit d984598

Please sign in to comment.