Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fr_FR v4.16 #43

Open
wants to merge 2 commits into
base: dataverse-v4.16
Choose a base branch
from

Conversation

tcoupin
Copy link
Contributor

@tcoupin tcoupin commented Sep 11, 2019

No description provided.

@tcoupin tcoupin force-pushed the dataverse-v4.16 branch 3 times, most recently from 9f3ce74 to 4b59953 Compare September 12, 2019 13:50
@mhvezina
Copy link
Collaborator

Bonjour Thibault,

Translation (fr_CA) for Dataverse v4.16 is already made and is aligned on the en_US files. Not sure why you want to merge fr_CA/*.properties files here. Would you mind giving us (@JayanthyChengan) more details about this part please?

Thanks.

@tcoupin
Copy link
Contributor Author

tcoupin commented Sep 13, 2019

Oh I didn't see fr_CA in dataverse-v4.16 branch when I pull on monday.
I will update my PR to remove modification on fr_CA.
This PR include deletion of duplicated rows, I will include it in my PR. It looks good for you?

@mhvezina
Copy link
Collaborator

Bonjour @tcoupin ,

It has been established that Bibliothèques de l'Université de Montréal is the "official" translator for the fr_CA version. For the fr_FR version, maybe you will want to check with the team at Sciences Po? They did the former translation for version 4.9.x. and are listed here as official maintainers. Your translation is obviously more up to date but I don't know exactly who is responsible for reviewing and merging the fr_FR part here (@pdurbin ?). As for the en_US files, my understanding is that they are not edited here and are copied from the main IQSS Github site (https://github.com/IQSS/dataverse/tree/v4.16/src/main/java/propertyFiles). Your modifications/corrections to those english files should be submitted there.

Bonne fin de journée,

Marie-Hélène

@pdurbin
Copy link
Member

pdurbin commented Sep 16, 2019

Hi! I don't have the power to merge pull requests here ( @4tikhonov does) and I don't speak French! (My daughter is studying French is school so maybe she'll be able to help out some day. 😄 ) Sorry I can't be of more help! Maybe @jri-sp from Sciences PO can help connect people. There's also @pmauduit who has been contributing a lot lately.

@4tikhonov
Copy link
Collaborator

@mhvezina, no worries, I'll ask Sciences Po if they can get French translation updated.
Will merge pull request for fr_CA now.

@mhvezina
Copy link
Collaborator

mhvezina commented Sep 16, 2019

@4tikhonov Please do not merge any fr_CA parts. This has already been taken care of (I do have the appropriate permissions here to do so).

For fr_FR parts, since Sciences Po was already a contributor I just suggested that they agree together on the submitted content.

Please note that @tcoupin said he will resubmit an updated version of his pull request. Maybe we could start from there.

@tcoupin
Copy link
Contributor Author

tcoupin commented Sep 16, 2019

Ok I remove fr_CA from my PR. I will ask to Sciences PO

@4tikhonov
Copy link
Collaborator

@mhvezina, @tcoupin, ok, great, no problem!

@tcoupin tcoupin changed the title Fr_FR and FR_CA v4.16 Fr_FR and -FR_CA- v4.16 Sep 16, 2019
@tcoupin tcoupin changed the title Fr_FR and -FR_CA- v4.16 Fr_FR v4.16 Sep 16, 2019
@gmi-cdsp
Copy link

@4tikhonov, there was the project to use weblate for dataverse translations, should I use it, what would you say ?
Geneviève

@4tikhonov
Copy link
Collaborator

@cdsp, yes, we can try weblate.dataverse.org. There are some issues with mail relay on Amazon but I can create an account for you.

@JayanthyChengan
Copy link
Collaborator

@tcoupin - static field for subject(staticSearchFields.subject) was not included in dataverse version 4.16, so it has to be added to new version or to develop branch. @mhvezina will work on translation once the version is released by dataverse team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants