🧮 Extended sequence number counter #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danstiner
commented
Apr 13, 2021
haydenmc
reviewed
Apr 19, 2021
| catch2_wrap.get_variable('catch2_dep'), | ||
| ] | ||
|
|
||
| exe = executable( |
There was a problem hiding this comment.
Not sure how I feel about having separate binaries for unit/functional/etc. test suites - does it make sense to build the individual suites as libraries that be linked into one big test executable?
There was a problem hiding this comment.
Thinking about it more, maybe it makes sense....
haydenmc
approved these changes
Apr 19, 2021
This was
linked to
issues
Apr 20, 2021
This was referenced Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this in an RFC and I think it will make tracking NACKs easier as we won't have to deal with wrapping of two-byte sequence numbers directly.
Includes actual tests!