Improve CSScomb support #623
Conversation
|
Following on from #209… |
|
@Glavin001 Not sure why this is failing? I don't think it has anything to do with the code I added… |
| LESS: false | ||
| Sass: false | ||
| SCSS: false | ||
| CSS: true |
There was a problem hiding this comment.
Change:
CSS: true
LESS: true
Sass: true
SCSS: true
to:
_:
configPath: true
predefinedConfig: true
CSS: true
LESS: true
Sass: true
SCSS: true
This allows only the options that are supported (configPath and predefinedConfig) and puts that for the default (_).
There was a problem hiding this comment.
This is the last thing that needs fixing. Right now it looks like all options are available, when it should be only configPath and predefinedConfig option. After that, re-run coffee docs/ to generate the correct documentation with only the allowed options. Thanks!
|
I usually ignore passing AppVeyor since Windows can be a PITA. It is currently passing Travis CI, which is what I require before merging Pull Requests, so this is good 👍. After you fix the above recommended changes, please run This is great. Good work so far! Will be able to merge this soon. Thanks. |
|
Can be?! |
Great! |
Add setting for custom config file path and support for CSON in addition to the standard JSON config. Signed-off-by: Daniel Bayley <[email protected]>
|
All sorted now as far as I can tell. The CI build is failing but since I'm getting deprecation warnings that include this package (since this last update to Atom itself) I'm guessing it's something to do with that… |
|
It's actually failing because of the Titanium Style Sheets tests. |
|
Thank you! |
|
Published to v0.28.17 |
Add setting for custom config file path and support for CSON in addition to the standard JSON config.
Signed-off-by: Daniel Bayley [email protected]