Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add --logs flag to local command #2187

Merged
merged 9 commits into from
Dec 8, 2023
Merged

feat: add --logs flag to local command #2187

merged 9 commits into from
Dec 8, 2023

Conversation

Lilit0x
Copy link
Contributor

@Lilit0x Lilit0x commented Dec 1, 2023 •
edited
Loading

Added --logs subcommand to local command. Defaults to debug.log when no file is provided.
Closes: #1357

vrongmeal
vrongmeal suggested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@vrongmeal vrongmeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments.

Also, the log file is implemented only for the "full" log mode. I think it should be implemented for all the modes.

crates/logutil/src/lib.rs Outdated Show resolved Hide resolved
crates/glaredb/tests/log_file_test.rs Show resolved Hide resolved
crates/glaredb/src/bin/main.rs Outdated Show resolved Hide resolved
@Lilit0x Lilit0x requested a review from vrongmeal December 6, 2023 19:57
vrongmeal
vrongmeal approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@vrongmeal vrongmeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! 🚀

@vrongmeal vrongmeal enabled auto-merge (squash) December 7, 2023 20:05
@universalmind303
Copy link
Contributor

@scsmithr @greyscaled can one of you manually merge this?

@scsmithr scsmithr disabled auto-merge December 8, 2023 00:04
@scsmithr scsmithr merged commit 45dcc23 into GlareDB:main Dec 8, 2023
8 of 9 checks passed
@universalmind303 universalmind303 mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrongmeal vrongmeal vrongmeal approved these changes

@tychoish tychoish tychoish approved these changes

@universalmind303 universalmind303 Awaiting requested review from universalmind303

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add --logs flag to local command
5 participants
@Lilit0x @universalmind303 @tychoish @vrongmeal @scsmithr