Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mobile view on scene list #2176

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Nov 29, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

Description of change

Improve responsive on scene list

Kapture.2024-11-29.at.11.24.20.mp4

Copy link

cloudflare-workers-and-pages bot commented Nov 29, 2024

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: a9de391
Status: ✅  Deploy successful!
Preview URL: https://d8527779.gladys-plus.pages.dev
Branch Preview URL: https://improve-response-scene-list.gladys-plus.pages.dev

View logs

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (6a1779d) to head (a9de391).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2176   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files         876      876           
  Lines       14409    14409           
=======================================
  Hits        14198    14198           
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Nov 29, 2024

#2902 Bundle Size — 10.41MiB (+0.03%).

a9de391(current) vs 6a1779d master#2900(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2902
     Baseline
#2900
No change  Initial JS 5.64MiB 5.64MiB
No change  Initial CSS 304.89KiB 304.89KiB
Change  Cache Invalidation 54.29% 0%
No change  Chunks 51 51
No change  Assets 173 173
No change  Modules 1511 1511
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#2902
     Baseline
#2900
Regression  JS 7.43MiB (+0.03%) 7.43MiB
No change  IMG 2.54MiB 2.54MiB
Regression  CSS 321.79KiB (+0.04%) 321.68KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.79KiB 17.79KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch improve-response-scene-listProject dashboard


Generated by RelativeCIDocumentationReport issue

@Pierre-Gilles Pierre-Gilles merged commit dfff5d2 into master Dec 2, 2024
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the improve-response-scene-list branch December 2, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant