Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of argument -rtsp_transport in ffmpeg command #2173

Merged

Conversation

cailholm
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Fix #2150 and #1787 : the argument -rtsp_transport must be placed before the -i argument otherwise it is not effective.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (8fff0ca) to head (958537b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2173      +/-   ##
==========================================
- Coverage   98.53%   98.53%   -0.01%     
==========================================
  Files         875      875              
  Lines       14386    14385       -1     
==========================================
- Hits        14175    14174       -1     
  Misses        211      211              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Nov 27, 2024

#2892 Bundle Size — 10.34MiB (0%).

958537b(current) vs 8fff0ca master#2883(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#2892
     Baseline
#2883
No change  Initial JS 5.62MiB 5.62MiB
No change  Initial CSS 304.89KiB 304.89KiB
Change  Cache Invalidation 0% 57.81%
No change  Chunks 51 51
No change  Assets 172 172
No change  Modules 1507 1507
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.84% 0.84%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  no changes
                 Current
#2892
     Baseline
#2883
No change  JS 7.41MiB 7.41MiB
No change  IMG 2.49MiB 2.49MiB
No change  CSS 321.68KiB 321.68KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.7KiB 17.7KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch cailholm:add-rtsp-transport-tcp-...Project dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR !

@Pierre-Gilles Pierre-Gilles merged commit 1643043 into GladysAssistant:master Nov 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants