Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(z2m): Hide Coordinator #2155

Merged

Conversation

cicoub13
Copy link
Contributor

@cicoub13 cicoub13 commented Nov 4, 2024

Fix #2154

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Remove Coordinator from Zigbee2Mqtt discovered devices

🐳 Docker image cicoub13/gladys:2154

Capture d’écran 2024-11-04 à 15 40 40

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.50%. Comparing base (3188ddf) to head (eaa4bfe).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2155   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files         867      867           
  Lines       14242    14243    +1     
=======================================
+ Hits        14029    14030    +1     
  Misses        213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Nov 4, 2024

#2826 Bundle Size — 10.25MiB (0%).

eaa4bfe(current) vs 3188ddf master#2824(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#2826
     Baseline
#2824
No change  Initial JS 5.55MiB 5.55MiB
No change  Initial CSS 304.68KiB 304.68KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 51 51
No change  Assets 171 171
No change  Modules 1495 1495
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.84% 0.84%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  no changes
                 Current
#2826
     Baseline
#2824
No change  JS 7.34MiB 7.34MiB
No change  IMG 2.48MiB 2.48MiB
No change  CSS 321.47KiB 321.47KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.62KiB 17.62KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch cicoub13:fix-z2m-hide-coordinato...Project dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR 🙏
Looks good to me!

@Pierre-Gilles Pierre-Gilles merged commit 216f637 into GladysAssistant:master Nov 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zigbee2mqtt: Add device undefined
2 participants