Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zigbee2mqtt : fix typos in new configuration process #2103

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)

Description of change

Fix typos

Copy link

cloudflare-workers-and-pages bot commented Jun 24, 2024

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4dd6cd3
Status: ✅  Deploy successful!
Preview URL: https://8816d86a.gladys-plus.pages.dev
Branch Preview URL: https://zigbee2mqtt-typos.gladys-plus.pages.dev

View logs

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (173a47b) to head (4dd6cd3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2103   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files         865      865           
  Lines       14169    14169           
=======================================
  Hits        13945    13945           
  Misses        224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Jun 24, 2024

#2664 Bundle Size — 10.18MiB (0%).

4dd6cd3(current) vs e83d529 master#2649(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#2664
     Baseline
#2649
No change  Initial JS 5.49MiB 5.49MiB
No change  Initial CSS 303.12KiB 303.12KiB
No change  Cache Invalidation 53.79% 53.79%
No change  Chunks 51 51
No change  Assets 171 171
No change  Modules 1490 1490
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  no changes
                 Current
#2664
     Baseline
#2649
No change  JS 7.27MiB 7.27MiB
No change  IMG 2.48MiB 2.48MiB
No change  CSS 319.91KiB 319.91KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.62KiB 17.62KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch zigbee2mqtt-typosProject dashboard

@Pierre-Gilles Pierre-Gilles merged commit 24d1a02 into master Jun 24, 2024
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the zigbee2mqtt-typos branch June 24, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant