Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Edit Box Devices component to improve device options filtering #2101

Conversation

Terdious
Copy link
Contributor

…ring

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

- [ ] If your changes affects code, did your write the tests?

  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
    - [ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
    - [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
    - [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
    - [ ] Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Like the device selection field in the box charts, addition of a filter in the selection field of the "Devices" box allowing all devices already selected to be removed from the list
image
image

@Terdious Terdious requested a review from Pierre-Gilles June 13, 2024 05:42
Copy link

relativeci bot commented Jun 13, 2024

#2647 Bundle Size — 10.18MiB (~+0.01%).

83db9b7(current) vs d450277 master#2645(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2647
     Baseline
#2645
Regression  Initial JS 5.49MiB(~+0.01%) 5.49MiB
No change  Initial CSS 303.12KiB 303.12KiB
Change  Cache Invalidation 53.79% 0%
No change  Chunks 51 51
No change  Assets 171 171
No change  Modules 1490 1490
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2647
     Baseline
#2645
Regression  JS 7.27MiB (~+0.01%) 7.27MiB
No change  IMG 2.48MiB 2.48MiB
No change  CSS 319.91KiB 319.91KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.62KiB 17.62KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch Terdious:edit-dashboard-refine-b...Project dashboard

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (d450277) to head (83db9b7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2101   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files         865      865           
  Lines       14169    14169           
=======================================
  Hits        13945    13945           
  Misses        224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me ! Thanks for this PR !

@Pierre-Gilles Pierre-Gilles merged commit e83d529 into GladysAssistant:master Jun 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants