Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix z-index issue on device.setValue scene action #2100

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Jun 10, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

Description of change

Fix #2098 & #2067

Copy link

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: b0774dd
Status: ✅  Deploy successful!
Preview URL: https://4e93b4a8.gladys-plus.pages.dev
Branch Preview URL: https://fix-z-index-issue-on-device.gladys-plus.pages.dev

View logs

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (4405399) to head (b0774dd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2100   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files         865      865           
  Lines       14162    14162           
=======================================
  Hits        13938    13938           
  Misses        224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Jun 10, 2024

#2633 Bundle Size — 10.18MiB (+0.01%).

b0774dd(current) vs 4405399 master#2630(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2633
     Baseline
#2630
Regression  Initial JS 5.49MiB(+0.02%) 5.48MiB
No change  Initial CSS 303.12KiB 303.12KiB
Change  Cache Invalidation 53.79% 0%
No change  Chunks 51 51
No change  Assets 171 171
No change  Modules 1490 1490
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2633
     Baseline
#2630
Regression  JS 7.27MiB (+0.02%) 7.27MiB
No change  IMG 2.48MiB 2.48MiB
No change  CSS 319.91KiB 319.91KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.62KiB 17.62KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch fix-z-index-issue-on-device-set-...Project dashboard

@Pierre-Gilles Pierre-Gilles merged commit c19ba07 into master Jun 13, 2024
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the fix-z-index-issue-on-device-set-value-scene branch June 13, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Z-index issue with shutter command button in scene action Control a device
1 participant