Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MELCloud integration for devices that doesn't have any model specified #2082

Merged
merged 1 commit into from
May 17, 2024

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

Copy link

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: a4319c1
Status: ✅  Deploy successful!
Preview URL: https://7d49d9c2.gladys-plus.pages.dev
Branch Preview URL: https://fix-melcloud-devices-no-mode.gladys-plus.pages.dev

View logs

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (7838bd6) to head (a4319c1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2082   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files         858      858           
  Lines       14038    14039    +1     
=======================================
+ Hits        13814    13815    +1     
  Misses        224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented May 17, 2024

#2557 Bundle Size — 10.13MiB (0%).

a4319c1(current) vs 7838bd6 master#2548(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#2557
     Baseline
#2548
No change  Initial JS 5.45MiB 5.45MiB
No change  Initial CSS 302.96KiB 302.96KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 51 51
No change  Assets 170 170
No change  Modules 1479 1479
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  no changes
                 Current
#2557
     Baseline
#2548
No change  JS 7.23MiB 7.23MiB
No change  IMG 2.46MiB 2.46MiB
No change  CSS 319.75KiB 319.75KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.53KiB 17.53KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch fix-melcloud-devices-no-modelProject dashboard

@Pierre-Gilles Pierre-Gilles merged commit 70feeaa into master May 17, 2024
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the fix-melcloud-devices-no-model branch May 17, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant