Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new risk feature #2068

Merged
merged 2 commits into from
May 9, 2024
Merged

Add new risk feature #2068

merged 2 commits into from
May 9, 2024

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented May 8, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

Description of change

Screenshot 2024-05-08 at 20 54 55
Screenshot 2024-05-08 at 20 55 06
Screenshot 2024-05-08 at 20 55 11
Screenshot 2024-05-08 at 20 55 17
Screenshot 2024-05-08 at 20 57 05

Copy link

cloudflare-pages bot commented May 8, 2024

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3b9fc02
Status: ✅  Deploy successful!
Preview URL: https://1b6a699f.gladys-plus.pages.dev
Branch Preview URL: https://add-new-risk-feature.gladys-plus.pages.dev

View logs

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (3854c30) to head (3b9fc02).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2068   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         850      850           
  Lines       13907    13907           
=======================================
  Hits        13683    13683           
  Misses        224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented May 8, 2024

#2535 Bundle Size — 10.11MiB (+0.02%).

3b9fc02(current) vs 3854c30 master#2534(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2535
     Baseline
#2534
Regression  Initial JS 5.43MiB(+0.02%) 5.42MiB
No change  Initial CSS 302.96KiB 302.96KiB
Change  Cache Invalidation 63.03% 53.57%
No change  Chunks 51 51
No change  Assets 170 170
No change  Modules 1478 1478
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2535
     Baseline
#2534
Regression  JS 7.21MiB (+0.03%) 7.21MiB
No change  IMG 2.46MiB 2.46MiB
No change  CSS 319.75KiB 319.75KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.53KiB 17.53KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch add-new-risk-featureProject dashboard

@Pierre-Gilles Pierre-Gilles merged commit cd825ab into master May 9, 2024
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the add-new-risk-feature branch May 9, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant