Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zigbee2mqtt: Add ikea somrig button #2035

Merged

Conversation

William-De71
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Ajout du bouton IKEA SOMRIG

image

https://www.zigbee2mqtt.io/devices/E2213.html

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (4a80cd8) to head (b34cb7a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2035   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         844      844           
  Lines       13738    13743    +5     
=======================================
+ Hits        13516    13521    +5     
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Mar 6, 2024

Job #2421: Bundle Size — 9.96MiB (~+0.01%).

b34cb7a(current) vs 94fb118 master#2415(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #2421
     Baseline
Job #2415
Regression  Initial JS 5.37MiB(+0.01%) 5.37MiB
No change  Initial CSS 303.21KiB 303.21KiB
Change  Cache Invalidation 53.8% 0%
No change  Chunks 51 51
No change  Assets 170 170
No change  Modules 1457 1457
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.79% 0.79%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #2421
     Baseline
Job #2415
Regression  JS 7.06MiB (+0.01%) 7.06MiB
Not changed  IMG 2.46MiB 2.46MiB
Not changed  CSS 319.71KiB 319.71KiB
Not changed  Fonts 93.55KiB 93.55KiB
Not changed  Other 17.53KiB 17.53KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #2421 reportView William-De71:add-ikea-somrig-but... branch activityView project dashboard

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me 👏

@Pierre-Gilles Pierre-Gilles merged commit 9d50528 into GladysAssistant:master Mar 8, 2024
9 checks passed
@William-De71 William-De71 deleted the add-ikea-somrig-button branch March 25, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants