Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to english forum in UI and Github repository #1873

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Sep 4, 2023

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.

Description of change

Add links to https://en-community.gladysassistant.com/ everywhere needed

@Pierre-Gilles Pierre-Gilles marked this pull request as ready for review September 4, 2023 16:17
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a8ea96a
Status: ✅  Deploy successful!
Preview URL: https://7e1e8f94.gladys-plus.pages.dev
Branch Preview URL: https://add-en-community-links-to-re.gladys-plus.pages.dev

View logs

@relativeci
Copy link

relativeci bot commented Sep 4, 2023

Job #1752: Bundle Size — 8.65MiB (~+0.01%).

a8ea96a(current) vs df87bc4 master#1749(baseline)

⚠️ Bundle contains 3 duplicate packages

Metrics (2 changes)
                 Current
Job #1752
     Baseline
Job #1749
Initial JS 4.69MiB(~+0.01%) 4.69MiB
Initial CSS 299.99KiB 299.99KiB
Cache Invalidation 54.03% 63.6%
Chunks 48 48
Assets 151 151
Modules 1359 1359
Duplicate Modules 19 19
Duplicate Code 0.69% 0.69%
Packages 124 124
Duplicate Packages 3 3
Total size by type (1 change)
                 Current
Job #1752
     Baseline
Job #1749
CSS 315.36KiB 315.36KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.92MiB 1.92MiB
JS 6.3MiB (~+0.01%) 6.3MiB
Media 0B 0B
Other 15.4KiB 15.4KiB

View job #1752 reportView add-en-community-links-to-repo-a... branch activity

@Pierre-Gilles Pierre-Gilles merged commit 3c545d2 into master Sep 8, 2023
12 of 15 checks passed
@Pierre-Gilles Pierre-Gilles deleted the add-en-community-links-to-repo-and-ui branch September 8, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant