Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zigbee2mqtt: New setup wizard & connection to external MQTT brokers #1872

Merged
merged 38 commits into from
May 3, 2024

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Sep 4, 2023

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Started from @atrovato work here: #1820

Screenshot 2024-04-26 at 17 16 20

@cloudflare-pages
Copy link

cloudflare-pages bot commented Sep 4, 2023

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0784a8c
Status: ✅  Deploy successful!
Preview URL: https://cbdef525.gladys-plus.pages.dev
Branch Preview URL: https://atrovato-z2m-setup-wizard.gladys-plus.pages.dev

View logs

Copy link

stale bot commented Nov 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 4, 2023
@stale stale bot closed this Nov 11, 2023
@Pierre-Gilles Pierre-Gilles reopened this Nov 30, 2023
Copy link

stale bot commented Jan 30, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 30, 2024
@stale stale bot closed this Feb 7, 2024
@Pierre-Gilles Pierre-Gilles reopened this Apr 4, 2024
@stale stale bot removed the stale label Apr 4, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 98.47328% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 98.38%. Comparing base (6f0bc73) to head (0784a8c).

Files Patch % Lines
...ver/services/zigbee2mqtt/lib/configureContainer.js 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1872      +/-   ##
==========================================
- Coverage   98.39%   98.38%   -0.01%     
==========================================
  Files         847      850       +3     
  Lines       13822    13890      +68     
==========================================
+ Hits        13600    13666      +66     
- Misses        222      224       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pierre-Gilles Pierre-Gilles marked this pull request as ready for review April 29, 2024 09:46
Copy link

relativeci bot commented Apr 29, 2024

#2522 Bundle Size — 10.1MiB (+0.26%).

0784a8c(current) vs 6f0bc73 master#2520(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 1 regression Improvement 1 improvement
                 Current
#2522
     Baseline
#2520
Regression  Initial JS 5.42MiB(+0.5%) 5.4MiB
Improvement  Initial CSS 302.96KiB(-0.08%) 303.21KiB
Change  Cache Invalidation 59.53% 53.45%
No change  Chunks 51 51
No change  Assets 170 170
Change  Modules 1478(+0.89%) 1465
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#2522
     Baseline
#2520
Regression  JS 7.21MiB (+0.37%) 7.18MiB
No change  IMG 2.46MiB 2.46MiB
Improvement  CSS 319.75KiB (-0.08%) 319.99KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.53KiB 17.53KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch atrovato-z2m-setup-wizardProject dashboard

@Pierre-Gilles Pierre-Gilles merged commit c28b59e into master May 3, 2024
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the atrovato-z2m-setup-wizard branch May 3, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants