Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devices in room widget should correctly refresh list of device features #1866

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Aug 31, 2023

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.

Description of change

Fix refresh of device in rooms edition widget

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6cdee54
Status: ✅  Deploy successful!
Preview URL: https://a2e43a61.gladys-plus.pages.dev
Branch Preview URL: https://fix-edit-device-in-room.gladys-plus.pages.dev

View logs

@relativeci
Copy link

relativeci bot commented Aug 31, 2023

Job #1719: Bundle Size — 8.64MiB (~+0.01%).

9ea09f8(current) vs ddaa068 master#1710(baseline)

⚠️ Bundle contains 3 duplicate packages

Metrics (2 changes)
                 Current
Job #1719
     Baseline
Job #1710
Initial JS 4.69MiB(~+0.01%) 4.69MiB
Initial CSS 302.01KiB 302.01KiB
Cache Invalidation 54.11% 63.67%
Chunks 47 47
Assets 150 150
Modules 1356 1356
Duplicate Modules 19 19
Duplicate Code 0.69% 0.69%
Packages 124 124
Duplicate Packages 3 3
Total size by type (1 change)
                 Current
Job #1719
     Baseline
Job #1710
CSS 315.31KiB 315.31KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.92MiB 1.92MiB
JS 6.29MiB (~+0.01%) 6.29MiB
Media 0B 0B
Other 15.29KiB 15.29KiB

View job #1719 reportView master branch activity

@Pierre-Gilles Pierre-Gilles merged commit 9ea09f8 into master Aug 31, 2023
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the fix-edit-device-in-room branch August 31, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant