-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to set custom name/position in device widget #1838
Conversation
Deploying with Cloudflare Pages
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1838 +/- ##
=======================================
Coverage 97.89% 97.89%
=======================================
Files 732 732
Lines 11281 11281
=======================================
Hits 11044 11044
Misses 237 237
☔ View full report in Codecov by Sentry. |
Job #1683: Bundle Size — 8.64MiB (~+0.01%).
Metrics (3 changes)
Total size by type (2 changes)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atrovato I fixed this bug since :) I'll fix the inline-css |
@atrovato @callemand I fixed both of your feedbacks :) If you want to check again that it's good for you! |
@atrovato @callemand Interested in your feedback after those fixes :) |
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)Description of change
Add new way to reorder and rename devices