Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set custom name/position in device widget #1838

Merged
merged 7 commits into from
Aug 25, 2023

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Jul 24, 2023

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.

Description of change

Add new way to reorder and rename devices

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 24, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a900dea
Status: ✅  Deploy successful!
Preview URL: https://9f125c20.gladys-plus.pages.dev
Branch Preview URL: https://re-order-device-widget-and-r.gladys-plus.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b17948c) 97.89% compared to head (a900dea) 97.89%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1838   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files         732      732           
  Lines       11281    11281           
=======================================
  Hits        11044    11044           
  Misses        237      237           
Files Changed Coverage Δ
server/models/dashboard.js 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pierre-Gilles Pierre-Gilles marked this pull request as ready for review July 24, 2023 14:46
@relativeci
Copy link

relativeci bot commented Jul 24, 2023

Job #1683: Bundle Size — 8.64MiB (~+0.01%).

5ceeba0(current) vs 404e1a6 master#1676(baseline)

⚠️ Bundle contains 3 duplicate packages

Metrics (3 changes)
                 Current
Job #1683
     Baseline
Job #1676
Initial JS 4.69MiB(+0.16%) 4.68MiB
Initial CSS 302.01KiB(+0.06%) 301.84KiB
Cache Invalidation 71.25% 0%
Chunks 47 47
Assets 150 150
Modules 1356 1356
Duplicate Modules 19 19
Duplicate Code 0.69% 0.69%
Packages 124 124
Duplicate Packages 3 3
Total size by type (2 changes)
                 Current
Job #1683
     Baseline
Job #1676
CSS 315.31KiB (+0.05%) 315.14KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.92MiB 1.92MiB
JS 6.29MiB (~+0.01%) 6.29MiB
Media 0B 0B
Other 15.29KiB 15.29KiB

View job #1683 reportView master branch activity

@Pierre-Gilles Pierre-Gilles requested review from callemand and atrovato and removed request for callemand July 24, 2023 15:54
Copy link
Contributor

@atrovato atrovato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite warnings about inline css, code looks good, but I think something is missing, I can't see the entire feature :

image

@Pierre-Gilles
Copy link
Contributor Author

Despite warnings about inline css, code looks good, but I think something is missing, I can't see the entire feature :

image

@atrovato I fixed this bug since :) I'll fix the inline-css

@Pierre-Gilles
Copy link
Contributor Author

@atrovato @callemand I fixed both of your feedbacks :) If you want to check again that it's good for you!

@Pierre-Gilles
Copy link
Contributor Author

@atrovato @callemand Interested in your feedback after those fixes :)

@Pierre-Gilles Pierre-Gilles merged commit 5ceeba0 into master Aug 25, 2023
12 checks passed
@Pierre-Gilles Pierre-Gilles deleted the re-order-device-widget-and-rename branch August 25, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants