Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isUsed function #1834

Merged
merged 2 commits into from
Jul 22, 2023
Merged

Conversation

callemand
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add isUsed function on Tuya

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0e3c876) 97.89% compared to head (80c4d10) 97.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1834   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files         732      732           
  Lines       11251    11253    +2     
=======================================
+ Hits        11014    11016    +2     
  Misses        237      237           
Impacted Files Coverage Δ
server/services/tuya/index.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🙏 Looks good to me!

@Pierre-Gilles Pierre-Gilles merged commit a5afdca into GladysAssistant:master Jul 22, 2023
@relativeci
Copy link

relativeci bot commented Jul 22, 2023

Job #1641: Bundle Size — 8.59MiB (0%).

a5afdca(current) vs 0e3c876 master#1630(baseline)

⚠️ Bundle contains 3 duplicate packages

Metrics (no changes)
                 Current
Job #1641
     Baseline
Job #1630
Initial JS 4.63MiB 4.63MiB
Initial CSS 301.84KiB 301.84KiB
Cache Invalidation 0% 0%
Chunks 47 47
Assets 150 150
Modules 1356 1356
Duplicate Modules 19 19
Duplicate Code 0.67% 0.67%
Packages 124 124
Duplicate Packages 3 3
Total size by type (no changes)
                 Current
Job #1641
     Baseline
Job #1630
CSS 315.14KiB 315.14KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.92MiB 1.92MiB
JS 6.24MiB 6.24MiB
Media 0B 0B
Other 15.29KiB 15.29KiB

View job #1641 reportView master branch activity

@callemand callemand deleted the isUsedTuya branch September 28, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants