Google Home: Should normalize brightness scale when controlling device with custom scale

[Pierre-Gilles]

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

• If your changes affects code, did your write the tests?
• Are tests passing? (npm test on both front/server)
• Is the linter passing? (npm run eslint on both front/server)
• Did you run prettier? (npm run prettier on both front/server)
• If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
• Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.

Description of change

Fix Google Home control of device with custom scale (0-254 for IKEA Tradfi for example)

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	53e1432
Status:	✅  Deploy successful!
Preview URL:	https://01b58222.gladys-plus.pages.dev
Branch Preview URL:	https://google-home-brightness-with.gladys-plus.pages.dev

View logs

[relativeci]

Job #1555: Bundle Size — 8.48MiB (0%).

8064531(current) vs 13205dc master#1539(baseline)

⚠️ Bundle contains 3 duplicate packages

Metrics (1 change)

	Current Job #1555	Baseline Job #1539
Initial JS	4.55MiB	4.55MiB
Initial CSS	301.27KiB	301.27KiB
Cache Invalidation	0%	53.58%
Chunks	47	47
Assets	149	149
Modules	1334	1334
Duplicate Modules	19	19
Duplicate Code	0.68%	0.68%
Packages	124	124
Duplicate Packages	3	3

Total size by type (no changes)

	Current Job #1555	Baseline Job #1539
CSS	314.41KiB	314.41KiB
Fonts	93.55KiB	93.55KiB
HTML	13.58KiB	13.58KiB
IMG	1.89MiB	1.89MiB
JS	6.16MiB	6.16MiB
Media	0B	0B
Other	15.21KiB	15.21KiB

---

View job #1555 report View master branch activity

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (13205dc) 97.82% compared to head (53e1432) 97.82%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1813   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files         706      705    -1     
  Lines       10908    10908           
=======================================
  Hits        10671    10671           
  Misses        237      237           

Impacted Files	Coverage Δ
...tions/lib/traits/googleActions.brightness.trait.js	100.00% <100.00%> (ø)
server/services/homekit/lib/buildService.js	98.85% <100.00%> (ø)
server/services/homekit/lib/sendState.js	100.00% <100.00%> (ø)
server/utils/device.js	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[atrovato]

Great! I will use it in many cases!