-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add send camera image action #1804
Add send camera image action #1804
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1804 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 705 706 +1
Lines 10881 10897 +16
=======================================
+ Hits 10643 10659 +16
Misses 238 238
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR ! 🙏
I wrote a few feedbacks :)
front/src/routes/scene/edit-scene/actions/SendMessageCameraParams.jsx
Outdated
Show resolved
Hide resolved
front/src/routes/scene/edit-scene/actions/SendMessageCameraParams.jsx
Outdated
Show resolved
Hide resolved
front/src/routes/scene/edit-scene/actions/SendMessageParams.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Job #1533: Bundle Size — 8.48MiB (+0.1%).
Metrics (3 changes)
Total size by type (1 change)
|
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)Description of change
Add new action into scene to send a message with image of camera.