Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add send camera image action #1804

Merged
merged 6 commits into from
Jun 9, 2023

Conversation

callemand
Copy link
Contributor

@callemand callemand commented May 31, 2023

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.

Description of change

Add new action into scene to send a message with image of camera.

Screenshot 2023-05-31 at 20 24 09
Screenshot 2023-05-31 at 20 24 15
Screenshot 2023-05-31 at 20 24 34
Screenshot 2023-05-31 at 20 24 46

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (922747e) 97.81% compared to head (9397614) 97.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1804   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files         705      706    +1     
  Lines       10881    10897   +16     
=======================================
+ Hits        10643    10659   +16     
  Misses        238      238           
Impacted Files Coverage Δ
server/models/scene.js 93.75% <ø> (ø)
server/utils/constants.js 100.00% <ø> (ø)
server/lib/device/camera/camera.getLiveImage.js 100.00% <100.00%> (ø)
server/lib/device/camera/index.js 100.00% <100.00%> (ø)
server/lib/device/index.js 100.00% <100.00%> (ø)
server/lib/scene/scene.actions.js 98.38% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@callemand callemand marked this pull request as ready for review May 31, 2023 18:26
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR ! 🙏

I wrote a few feedbacks :)

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick changes! I tested locally and it works fine!

I have a small feedback, the title of the action is a bit long and it doesn't look that good:

Screenshot 2023-06-02 at 14 55 41 Screenshot 2023-06-02 at 14 54 26

Any idea for a smaller title? Or a way to make it nicer?

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way better with that title!

Thanks for the changes 👏

Screenshot 2023-06-09 at 11 12 02

@Pierre-Gilles Pierre-Gilles merged commit ff00cc3 into GladysAssistant:master Jun 9, 2023
@relativeci
Copy link

relativeci bot commented Jun 9, 2023

Job #1533: Bundle Size — 8.48MiB (+0.1%).

ff00cc3(current) vs 5adb02f master#1530(baseline)

⚠️ Bundle contains 3 duplicate packages

Metrics (3 changes)
                 Current
Job #1533
     Baseline
Job #1530
Initial JS 4.55MiB(+0.19%) 4.54MiB
Initial CSS 301.27KiB 301.27KiB
Cache Invalidation 53.53% 0%
Chunks 47 47
Assets 149 149
Modules 1334(+0.08%) 1333
Duplicate Modules 19 19
Duplicate Code 0.68% 0.68%
Packages 124 124
Duplicate Packages 3 3
Total size by type (1 change)
                 Current
Job #1533
     Baseline
Job #1530
CSS 314.41KiB 314.41KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.89MiB 1.89MiB
JS 6.16MiB (+0.14%) 6.15MiB
Media 0B 0B
Other 15.21KiB 15.21KiB

View job #1533 reportView master branch activity

@callemand callemand deleted the SendImageCamera branch July 11, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants