Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request entity too large bug on save of camera #1793

Merged
merged 1 commit into from
May 19, 2023

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented May 19, 2023

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.

Description of change

Fix https://en-community.gladysassistant.com/t/help-with-adding-a-camera/99/5?u=pierre-gilles

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c3071e6
Status: ✅  Deploy successful!
Preview URL: https://588203ec.gladys-plus.pages.dev
Branch Preview URL: https://camera-save-without-image.gladys-plus.pages.dev

View logs

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (31874a2) 97.80% compared to head (c3071e6) 97.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1793   +/-   ##
=======================================
  Coverage   97.80%   97.80%           
=======================================
  Files         705      705           
  Lines       10872    10872           
=======================================
  Hits        10633    10633           
  Misses        239      239           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@relativeci
Copy link

relativeci bot commented May 19, 2023

Job #1468: Bundle Size — 8.55MiB (~+0.01%).

bd9c38b(current) vs 31874a2 master#1462(baseline)

⚠️ Bundle contains 3 duplicate packages

Metrics (2 changes)
                 Current
Job #1468
     Baseline
Job #1462
Initial JS 4.54MiB(~+0.01%) 4.54MiB
Initial CSS 301.27KiB 301.27KiB
Cache Invalidation 52.98% 0%
Chunks 51 51
Assets 153 153
Modules 1340 1340
Duplicate Modules 20 20
Duplicate Code 0.63% 0.63%
Packages 124 124
Duplicate Packages 3 3
Total size by type (1 change)
                 Current
Job #1468
     Baseline
Job #1462
CSS 314.41KiB 314.41KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.89MiB 1.89MiB
JS 6.23MiB (~+0.01%) 6.23MiB
Media 0B 0B
Other 16.04KiB 16.04KiB

View job #1468 reportView master branch activity

@Pierre-Gilles Pierre-Gilles merged commit bd9c38b into master May 19, 2023
@Pierre-Gilles Pierre-Gilles deleted the camera-save-without-image branch May 19, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant