Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera: Add warning message when bandwidth limitation is reached #1775

Merged
merged 2 commits into from
May 12, 2023

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented May 8, 2023

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.

Description of change

Add warning message when bandwidth limit is reached

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 8, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2d0f57c
Status: ✅  Deploy successful!
Preview URL: https://5d98b1b0.gladys-plus.pages.dev
Branch Preview URL: https://add-camera-limitations.gladys-plus.pages.dev

View logs

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a5b608c) 97.78% compared to head (2d0f57c) 97.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1775   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files         698      698           
  Lines       10779    10780    +1     
=======================================
+ Hits        10540    10541    +1     
  Misses        239      239           
Impacted Files Coverage Δ
...ervices/rtsp-camera/lib/sendCameraFileToGateway.js 100.00% <100.00%> (ø)
server/services/rtsp-camera/lib/startStreaming.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@relativeci
Copy link

relativeci bot commented May 8, 2023

Job #1407: Bundle Size — 8.54MiB (+0.01%).

e507087(current) vs 2d808c1 master#1399(baseline)

⚠️ Bundle contains 5 duplicate packages

Metrics (2 changes)
                 Current
Job #1407
     Baseline
Job #1399
Initial JS 4.54MiB(+0.01%) 4.54MiB
Initial CSS 300.89KiB 300.89KiB
Cache Invalidation 63.17% 0%
Chunks 51 51
Assets 153 153
Modules 1341 1341
Duplicate Modules 20 20
Duplicate Code 0.64% 0.64%
Packages 125 125
Duplicate Packages 4 4
Total size by type (1 change)
                 Current
Job #1407
     Baseline
Job #1399
CSS 314.02KiB 314.02KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.89MiB 1.89MiB
JS 6.22MiB (+0.02%) 6.22MiB
Media 0B 0B
Other 16.04KiB 16.04KiB

View job #1407 reportView master branch activity

@Pierre-Gilles Pierre-Gilles merged commit e507087 into master May 12, 2023
@Pierre-Gilles Pierre-Gilles deleted the add-camera-limitations branch May 12, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant