Scene action toggle

[rpochet]

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

• [ x] If your changes affects code, did your write the tests?
• [ x] Are tests passing? (npm test on both front/server)
• [ x] Is the linter passing? (npm run eslint on both front/server)
• [ x] Did you run prettier? (npm run prettier on both front/server)
• [ x] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
• [ x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
• If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
• If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
• Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add action toggle ON <> OFF to scene

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1222d3f) 97.65% compared to head (ae3bbc0) 97.65%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1645   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files         678      678           
  Lines       10305    10317   +12     
=======================================
+ Hits        10063    10075   +12     
  Misses        242      242           

Impacted Files	Coverage Δ
server/utils/constants.js	100.00% <ø> (ø)
server/lib/scene/scene.actions.js	98.24% <100.00%> (+0.13%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Pierre-Gilles]

@rpochet Tell me when this is ready for review :)

[rpochet]

C'est bon pour moi

[Pierre-Gilles]

Thanks for this PR 🙏

it works fine on my side, good job!

Just a little UX feedback, maybe we should explain in the action what does this action do?

Like a little text saying "Si les lumières sont allumées, elle seront éteintes, et vice-versa".

What do you think?

[Pierre-Gilles]

Good for me now with the changes! Thanks for taking the time 🙏

[relativeci]

Job #1328: Bundle Size — 7.57MiB (+0.04%).

f704335(current) vs 1222d3f master#1326(baseline)

⚠️ Bundle contains 5 duplicate packages

Metrics (2 changes)

	Current Job #1328	Baseline Job #1326
Initial JS	4.49MiB(+0.07%)	4.49MiB
Initial CSS	300.37KiB	300.37KiB
Cache Invalidation	59.21%	60.85%
Chunks	51	51
Assets	152	152
Modules	1335	1335
Duplicate Modules	20	20
Duplicate Code	0.75%	0.75%
Packages	123	123
Duplicate Packages	4	4

Total size by type (1 change)

	Current Job #1328	Baseline Job #1326
CSS	313.5KiB	313.5KiB
Fonts	93.55KiB	93.55KiB
HTML	13.58KiB	13.58KiB
IMG	1.73MiB	1.73MiB
JS	5.41MiB (+0.06%)	5.41MiB
Media	0B	0B
Other	15.97KiB	15.97KiB

---

View job #1328 report View master branch activity