-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Coregistration Functionality for CLI #629
base: main
Are you sure you want to change the base?
Conversation
Great! 🙂 I don't have much to comment on the code, my main remark at this stage is rather on the structure: Should we already anticipate other CLI usage than coregistration (e.g., terrain attributes, uncertainty)? If yes, we could potentially separate into different namings, for instance by adding a first parameter to the parsing: Small remarks:
inlier_rst = coreg_dem.copy(new_array=inlier_mask)
inlier_rst.save("xxx.tif") |
8f53ba9
to
42c96dc
Compare
Thanks for your feedback @rhugonnet.
|
f050c91
to
45fcd54
Compare
45fcd54
to
e4e4cb4
Compare
Resolves #622 and #623
Description
This PR implements the coregistration functionality for the CLI. The aim is to enhance the xdem run by adding the necessary functions to verify the existence of both input paths and executing the coregistration of DEMs.
Key Changes:
Path Verification:
Loading DEMs:
geoutils.rasters.load_multiple_rasters
accessor to load the reference and secondary DEMs:Coregistration Execution:
Integrated the
dem_coregistration
function from theworkflows
module to perform the coregistration:The aligned DEM is saved as
aligned_dem.tiff
, and the inlier mask is saved asinlier_mask.tiff
.Output Verification:
Testing:
Developed tests to retrieve test data and validate the outputs against ground truth data as specified in
tests/test_cli.py
.Documentation
Updated the Quick Start Guide in the documentation to reflect the new coregistration capabilities and usage instructions.
Future Work:
As #617 is not merged yet, the changes made do not take account of the change of licence. After #617 merge, this PR should be update with a header for
xdem_cli.py
and a description of the packageargcomplete
in the NOTICE file.