Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for forcing source type #153

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

Barabazs
Copy link
Contributor

This PR adds support to force the source type, as discussed in #151.

  • It adds a new CLI argument --source, which is passed to the choose_provider function.
  • The choose_provider is updated to handle this new feature.
  • A test case has been added for this feature.

@Barabazs
Copy link
Contributor Author

Barabazs commented Dec 9, 2024

Friendly 🆙

@GjjvdBurg GjjvdBurg merged commit 109d625 into GjjvdBurg:master Dec 9, 2024
0 of 2 checks passed
@GjjvdBurg
Copy link
Owner

Thanks for this one too!

@Barabazs Barabazs deleted the feat/force-source branch December 10, 2024 13:20
GjjvdBurg added a commit that referenced this pull request Jan 4, 2025
* Add support for uploading through USB (thanks to @sachiniyer in #155)
* Add support for forcing source type (thanks to @Barabazs in #153)
* Migrate regex url validation to validators library (thanks to @Barabazs in
  #152)
* Update the Dockerfile (thanks to @Barabazs in #150)
* Update documentation to link to rmapi fork (thanks to @Barabazs in #149)
* Various fixes to broken providers and unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants