Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add multiupdate settings #4

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

CarlosQ96
Copy link
Contributor

This was a talk with Ramin and Moe for enhancing the performance.

@@ -6,6 +6,30 @@ import {
import { MICRO_SERVICES, THIRD_PARTY_EMAIL_SERVICES } from '../src/utils/utils';

export const GivethNotificationTypes = {
EMAIL_NOTIFICATIONS: {
Copy link
Contributor Author

@CarlosQ96 CarlosQ96 Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This are two global notifications settings

Copy link
Contributor

@mohammadranjbarz mohammadranjbarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @CarlosQ96 , sorry for not reviewing sooner

@mohammadranjbarz mohammadranjbarz merged commit d007c69 into staging Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants