Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify project update added - Users who supported notificationType #32

Merged
merged 4 commits into from
Jan 24, 2023
Merged

Modify project update added - Users who supported notificationType #32

merged 4 commits into from
Jan 24, 2023

Conversation

mohammadranjbarz
Copy link
Contributor

@mohammadranjbarz
Copy link
Contributor Author

mohammadranjbarz commented Jan 23, 2023 •
edited
Loading

Fix #817 as well

@mohammadranjbarz mohammadranjbarz mentioned this pull request Jan 23, 2023
Merged
@mohammadranjbarz
Copy link
Contributor Author

This PR and Giveth/impact-graph#814 should get merged at the same time

@mohammadranjbarz mohammadranjbarz marked this pull request as ready for review January 23, 2023 13:47
CarlosQ96
CarlosQ96 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@CarlosQ96 CarlosQ96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me Mohammad, I didn't see any typos and names match with impact graph pr.

@mohammadranjbarz mohammadranjbarz merged commit cc16d5d into staging Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosQ96 CarlosQ96 CarlosQ96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohammadranjbarz @CarlosQ96