Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests and fix issues. #3

Merged
merged 9 commits into from
Aug 29, 2022
Merged

Add tests and fix issues. #3

merged 9 commits into from
Aug 29, 2022

Conversation

CarlosQ96
Copy link
Contributor

  1. Fixed notification settings initialization was failing.
  2. Added userAddress repository tests

@CarlosQ96 CarlosQ96 marked this pull request as ready for review August 28, 2022 06:01
mohammadranjbarz
mohammadranjbarz approved these changes Aug 28, 2022
View reviewed changes
Copy link
Contributor

@mohammadranjbarz mohammadranjbarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CarlosQ96 , LGTM
If I merge it our staging may go down :))
So I just approve it, we can merge it later

@mohammadranjbarz mohammadranjbarz merged commit 4e4c234 into staging Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammadranjbarz mohammadranjbarz mohammadranjbarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CarlosQ96 @mohammadranjbarz @cquinterom096