Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated givback is ready event template #27

Merged
merged 2 commits into from
Dec 27, 2022
Merged

Updated givback is ready event template #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4aa5451
Updated givback is ready event template / 3
aminlatifi Dec 27, 2022
94e0e7a
Updated giback claim is ready tests to match new microservice type
aminlatifi Dec 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions migrations/1660716115917-seedNotificationType.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,7 +948,7 @@ export const GivethNotificationTypes = {
title: 'GIVback',
description: 'When GIVback is ready to be claimed after each round',
showOnSettingPage: true,
microService: MICRO_SERVICES.givethio,
microService: MICRO_SERVICES.givEconomyNotificationMicroService,
category: NOTIFICATION_CATEGORY.GIV_ECONOMY,
icon: 'IconGIVBack',
schemaValidator: SCHEMA_VALIDATORS_NAMES.GIV_BACK_IS_READY_TO_CLAIM,
Expand Down Expand Up @@ -980,7 +980,7 @@ export const GivethNotificationTypes = {
},
],
content:
'Your GIVback {amount} GIV is ready to claim! \n{Click here} to take a shortcut.',
'Your GIVback {amount} GIV is ready to claim! \n[Click here] to take a shortcut.',
},
PROJECT_EDITED: {
name: 'Project edited',
Expand Down
4 changes: 2 additions & 2 deletions src/routes/v1/notificationRouter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1445,7 +1445,7 @@ function sendNotificationTestCases() {

const result = await axios.post(sendNotificationUrl, data, {
headers: {
authorization: getGivethIoBasicAuth(),
authorization: getGivEconomyBasicAuth(),
},
});
assert.equal(result.status, 200);
Expand All @@ -1468,7 +1468,7 @@ function sendNotificationTestCases() {

await axios.post(sendNotificationUrl, data, {
headers: {
authorization: getGivethIoBasicAuth(),
authorization: getGivEconomyBasicAuth(),
},
});
// If request doesn't fail, it means this test failed
Expand Down