Implement sending bulk notifications #26
Conversation
There was a problem hiding this comment.
Thanks @mohammadranjbarz , It looks good.
Just one concern must be addressed, mentioned in another comment
| const { microService } = params; | ||
| try { | ||
| validateWithJoiSchema(body, sendBulkNotificationValidator); | ||
| await Promise.all( |
There was a problem hiding this comment.
What will happen if two events have the same trackId? We have made that field unique in the schema, so normally it must throw an error! but the problem is that some notifications will be created and some not!
@mohammadranjbarz Can you write a test to examine it?
If you agree with to change it, the best way in my view is to put all tackIds in a Set and compare its size with the notifications size.
There was a problem hiding this comment.
Note, only duplicates in current notifications may cause a problem. If we have a trackId saved before this request, it will only gracefully ignored.
There was a problem hiding this comment.
Thanks @aminlatifi , your suggestion was good, I did it.
…ulk notifications related to #24
related to #24