Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F 14 add track id to notification #15

Merged
merged 4 commits into from
Nov 23, 2022
Merged

F 14 add track id to notification #15

merged 4 commits into from
Nov 23, 2022

Conversation

mohammadranjbarz
Copy link
Contributor

related to #14

CarlosQ96
CarlosQ96 approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@CarlosQ96 CarlosQ96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mohammad, LGTM!
I checked:
Uniqueness at db and entity level (good!)
Endpoint validations

Thanks for refactoring types and removing old console logs.

I just fixed a minor past tense typo.
You can merge!

@mohammadranjbarz
Copy link
Contributor Author

Thanks Mohammad, LGTM! I checked: Uniqueness at db and entity level (good!) Endpoint validations

Thanks for refactoring types and removing old console logs.

I just fixed a minor past tense typo. You can merge!

Thanks @CarlosQ96 , mucho gracias

@mohammadranjbarz mohammadranjbarz merged commit 1b82e33 into staging Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosQ96 CarlosQ96 CarlosQ96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohammadranjbarz @CarlosQ96 @cquinterom096