Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Center - Copy Fixes & Some extra Changes.... #29

Closed
16 tasks done
laurenluz opened this issue Jan 9, 2023 · 22 comments
Closed
16 tasks done

Notification Center - Copy Fixes & Some extra Changes.... #29

laurenluz opened this issue Jan 9, 2023 · 22 comments
Assignees

Comments

@laurenluz
Copy link
Member

laurenluz commented Jan 9, 2023

Ok, I have many copy suggestions for this page. I hope they are clear. I also added a few questions/change requests here. Lmk if anything doesn't make sense.

cc @maryjaf @MohammadPCh

@laurenluz laurenluz changed the title Notification Settings Page - Copy Fixes & Some extra Changes.... Notification Center - Copy Fixes & Some extra Changes.... Jan 9, 2023
@laurenluz
Copy link
Member Author

laurenluz commented Jan 9, 2023

  • Your history of notifications, starting with the most recent.
    image

  • Can we change the sorting here? "All" "General" "My projects" "Supported projects" "Rewards" @MoeNick ? I don't like lumping together project activity for a projects owner & for a donor
    image

@MohammadPCh MohammadPCh self-assigned this Jan 11, 2023
@MohammadPCh
Copy link
Collaborator

@alireza-sharifpour can you take it?

@alireza-sharifpour
Copy link
Member

@alireza-sharifpour can you take it?

Sure, I'll take it

@laurenluz
Copy link
Member Author

I think @MoeNick wanted to do a bit of review on this @alireza-sharifpour ...

so if there are some suggestions that I made w/ a comment to @MoeNick, skip those until he gives the thumbs up

@MoeNick
Copy link
Member

MoeNick commented Jan 16, 2023

You can start te copy fixes @alireza-sharifpour
There are some design changes that you can see on the Figma, jfyi on tabs and on setting page we added supported projects notification.

@alireza-sharifpour
Copy link
Member

alireza-sharifpour commented Jan 18, 2023

@MoeNick We get settings copies from the backend, so i think there would be some changes in the backend side.
@mohammadranjbarz @CarlosQ96

@MoeNick
Copy link
Member

MoeNick commented Jan 18, 2023

I think we have to include it in related backend issue.

@MoeNick
Copy link
Member

MoeNick commented Jan 19, 2023

I assigned it to @mohammadranjbarz cause most of them need db changes

@mohammadranjbarz
Copy link
Contributor

@laurenluz

About below question that you asked, yes we just send one notification per user-project to projectOwner, when someone likes/boosts a project

Screen Shot 1401-11-05 at 11 01 40

@mohammadranjbarz
Copy link
Contributor

@maryjaf @MoeNick This issue has been implemented and merged
you can test it here

https://notification-center-13.vercel.app/notifications/settings

@maryjaf
Copy link

maryjaf commented Jan 25, 2023

  • Your history of notifications, starting with the most recent.

image

In this section the old message is shown

@maryjaf
Copy link

maryjaf commented Jan 25, 2023

  • Important notifications outside of your settings may still be sent to you.

and this:
image

@maryjaf
Copy link

maryjaf commented Jan 25, 2023

  • "Send me an email" "Notify me in the DApp"

image

@maryjaf
Copy link

maryjaf commented Jan 25, 2023

image

"Supported project updated" is duplicated

@maryjaf
Copy link

maryjaf commented Jan 25, 2023

image

@mohammadranjbarz
Copy link
Contributor

Your history of notifications, starting with the most recent.

image

In this section the old message is shown

@maryjaf @MohammadPCh @alireza-sharifpour It's related to frontend

@mohammadranjbarz
Copy link
Contributor

Important notifications outside of your settings may still be sent to you.

and this: image

@maryjaf @MohammadPCh @alireza-sharifpour It's related to frontend

@mohammadranjbarz
Copy link
Contributor

"Send me an email" "Notify me in the DApp"

image

@maryjaf @MohammadPCh @alireza-sharifpour It's related to frontend

@mohammadranjbarz
Copy link
Contributor

mohammadranjbarz commented Jan 30, 2023

image

"Supported project updated" is duplicated

@maryjaf Thanks for finding this, I deleted the repetitive one

@maryjaf
Copy link

maryjaf commented Feb 1, 2023

image

Is this related to frontend or backend? @mohammadranjbarz

@mohammadranjbarz
Copy link
Contributor

image

Is this related to frontend or backend? @mohammadranjbarz

No it's related to backend, thanks for mentioning that, I had forgotten about it, I added this comment

#31 (comment)

@maryjaf
Copy link

maryjaf commented Feb 7, 2023

Thanks @alireza-sharifpour copy related to frontend has been edited

@maryjaf maryjaf closed this as completed Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants