Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture status change events in edit project page in admin bro #729

Closed
mohammadranjbarz opened this issue Nov 17, 2022 · 10 comments
Closed
Assignees

Comments

@mohammadranjbarz
Copy link
Collaborator

When user changes verified, listed or changing status of projects to one activated , deactivated and cancelled we should send notification (and email if it's needed)

Screen Shot 1401-08-26 at 12 05 03

@mohammadranjbarz mohammadranjbarz self-assigned this Nov 17, 2022
mohammadranjbarz added a commit that referenced this issue Nov 17, 2022
@mohammadranjbarz
Copy link
Collaborator Author

@maryjaf @MoeNick
It's on staging now

@maryjaf
Copy link
Collaborator

maryjaf commented Nov 22, 2022

@maryjaf @MoeNick It's on staging now

I think this problem is not completely solved @mohammadranjbarz
Because when I change the project from the edit page to the listed status, I do not receive a notification
But when I make this change from the list, I receive this notification: Nice! Your testfilterr project is listed.

When I unlist the project from the edit page, I get a notification as a who that like this project not project owner (i liked my project): The testfilterr that you liked is no longer visible.
and when unlist project from list i receive two notification as who liked project and project owner :
The testfilterr that you liked is no longer visible.
6 seconds ago
Your testfilterr project is no longer visible.
6 seconds ago


And in general, now we don't get notified based on the status change, if I just click, I get notified
For example, the status of my project is listed, if the admin user hits the list again, even though the status has not changed, a notification will be sent.
is that ok? @mohammadranjbarz @MoeNick

@mohammadranjbarz
Copy link
Collaborator Author

mohammadranjbarz commented Nov 23, 2022

@maryjaf @MoeNick It's on staging now

I think this problem is not completely solved @mohammadranjbarz Because when I change the project from the edit page to the listed status, I do not receive a notification But when I make this change from the list, I receive this notification: Nice! Your testfilterr project is listed.

When I unlist the project from the edit page, I get a notification as a who that like this project not project owner (i liked my project): The testfilterr that you liked is no longer visible. and when unlist project from list i receive two notification as who liked project and project owner : The testfilterr that you liked is no longer visible. 6 seconds ago Your testfilterr project is no longer visible. 6 seconds ago

And in general, now we don't get notified based on the status change, if I just click, I get notified For example, the status of my project is listed, if the admin user hits the list again, even though the status has not changed, a notification will be sent. is that ok? @mohammadranjbarz @MoeNick

I didn't get this part of your comments

if I just click, I get notified
For example, the status of my project is listed, if the admin user hits the list again, even though the status has not changed, a notification will be sent.

Can you give me a screenshot about it?

@MoeNick Yeah Maryam is right, we have problem that didn't think about it, if some is owner of the project, liked the project and donated to that, will receive 3 notification on some events, what should we do in these cases?
(There would be some other variations as well, for instance someone who liked and donated to a project, or someone who ownes and donated, ...)

@maryjaf
Copy link
Collaborator

maryjaf commented Dec 13, 2022

when I changed status of project or listed/unlisted from edit page I didn't receive notification and email @mohammadranjbarz

@mohammadranjbarz
Copy link
Collaborator Author

when I changed status of project or listed/unlisted from edit page I didn't receive notification and email @mohammadranjbarz

@CarlosQ96 has fixed that and we deployed it.
@maryjaf please test it again

@maryjaf
Copy link
Collaborator

maryjaf commented Dec 19, 2022

when I changed status of project or listed/unlisted from edit page I didn't receive notification and email @mohammadranjbarz

@CarlosQ96 has fixed that and we deployed it. @maryjaf please test it again

Thanks @CarlosQ96 @mohammadranjbarz
I tested Notification and the emails that we tested earlier and it was OK from the list, now it has passed in the edit page as well.

Below scenario also needs to be checked, but it is clearly not related to the edit page. If it is necessary to comment on another issue, let me know.
-We have notifications that are sent to the project owner, but not to those who liked the project (both the list page and edit page)

  • Listed project
  • Activate project
  • Verify/Unverify

@mohammadranjbarz
Copy link
Collaborator Author

I would appreciate it, if you can make separate issues for each item that you mentioned

@mohammadranjbarz
Copy link
Collaborator Author

I would appreciate it, if you can make separate issues for each item that you mentioned

@maryjaf

@maryjaf
Copy link
Collaborator

maryjaf commented Dec 22, 2022

I would appreciate it, if you can make separate issues for each item that you mentioned

@maryjaf

Sure,
Giveth/notification-center#22

@MoeNick
Copy link
Member

MoeNick commented Jan 23, 2023

related to #809 beacyse we changed the subscribers concept

@MoeNick MoeNick closed this as completed Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants