Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate AND verify stuck & missing donations #1556

Closed
divine-comedian opened this issue May 11, 2024 · 13 comments
Closed

Investigate AND verify stuck & missing donations #1556

divine-comedian opened this issue May 11, 2024 · 13 comments
Assignees

Comments

@divine-comedian
Copy link
Collaborator

On thursday/friday a user reported their donations were not showing up on ETH mainnet to this project

https://giveth.io/project/emergency-relief-fund-for-brazil-floods

I was able to confirm this by making a donation myself in ETH to their project on mainnet, I cannot find the donation in 'my donations' or on the project table, nor in the back-up service.

Here are the three donations we know of that we're not caught anywhere:
https://etherscan.io/tx/0x331ff224c7e4dcc3ce9bb6aa6b3a67e1d7b1c7f1c27e6fdead150fd09a6499b6
https://etherscan.io/tx/0xf1a4fb4c446c25529fed988c83381db41fd6cbbe8aae69a58f2a93a60a8b9f73
https://etherscan.io/tx/0x0373f7efaeb12c205e2c26f2b14a49194b9e619c6728c8a5a4f8cf36f635ef6f

Alternatively, when I was testing donations to other projects on ETH mainnet my donations show up in my donations but they are stuck in a pending state, I also cannot find them in the back-up service. I made some donations on Optimism mainnet and encountered no issues for comarison.

image

Here are the txs for my stuck pending donations:
https://etherscan.io/tx/0xc81021a481b1a21947b1aed7199cd7febdd662cd9a4ee839eb734849b59b24c2
https://etherscan.io/tx/0x5c4cab8d517393178a6f59af693185848c57b21975710cb71f706e8984b117db


I tested today, late friday making a donation on eth mainnet this donation was successful and show on my donations and the projects donations table. however the previous donations on eth mainnet do not show.

How did this happen? We should 1st add the missing donations into our DB. 2nd we need to investigate how this happens that donations are stuck as pending and how it can occuer that other donations are just not caught by any service at all, but only for eth mainnet

@divine-comedian
Copy link
Collaborator Author

divine-comedian commented May 12, 2024

Also, there is 61 failed donations in the back-up service that needed to be checked they have been added back to our UI! This is from last week when the donation verification service went down unexpectedly.

image

@divine-comedian divine-comedian added p0 and removed p1 labels May 12, 2024
@mohammadranjbarz
Copy link
Collaborator

@divine-comedian
I checked the DB for your first three transactions (https://etherscan.io/tx/0x331ff224c7e4dcc3ce9bb6aa6b3a67e1d7b1c7f1c27e6fdead150fd09a6499b6, https://etherscan.io/tx/0xf1a4fb4c446c25529fed988c83381db41fd6cbbe8aae69a58f2a93a60a8b9f73,
https://etherscan.io/tx/0x0373f7efaeb12c205e2c26f2b14a49194b9e619c6728c8a5a4f8cf36f635ef6f)
We have them in the DB in draft_donation table, and they are not matched(Still pending) so this is the problem that is why we haven't matched them although they have been successful.

And about the other two TXs that @divine-comedian mentioned, now we have the TXs in our db for those, so there isn't any problem related to them
https://etherscan.io/tx/0xc81021a481b1a21947b1aed7199cd7febdd662cd9a4ee839eb734849b59b24c2
https://etherscan.io/tx/0x5c4cab8d517393178a6f59af693185848c57b21975710cb71f706e8984b117db

TL;DR
Unfortunately, our draft donation service doesn't work properly.

I will post more details as I find any reason

@geleeroyale
Copy link
Collaborator

image

Thanks @mohammadranjbarz - unfortunately I was not able to replicate the issue @divine-comedian was facing (my donation showed instantly and as complete) which leads me to concur with @mohammadranjbarz that we need to take a look at backup service.

I was investigating a lead regarding outdated infura endpoints (which I would still like to revisit, but need someone from frontend to take a look) but seeing it works now I am assuming the problem was temporary. I did check for incidents on infuras side for the relevant time, but nothing out of the ordinary.

mohammadranjbarz added a commit that referenced this issue May 13, 2024
… sure the failure of that doesnt have any side effect on our application

related to #1556
mohammadranjbarz added a commit that referenced this issue May 13, 2024
… sure the failure of that doesnt have any side effect on our application (#1563)

related to #1556
@divine-comedian divine-comedian changed the title Investigate AND verify stuck & missing mainnet donations Investigate AND verify stuck & missing donations May 13, 2024
@mohammadranjbarz
Copy link
Collaborator

So far from user reports we're missing the following donations:

https://giveth.io/project/emergency-relief-fund-for-brazil-floods

https://giveth.io/es/project/skatehive-skateboarding-community?tab=donations

@divine-comedian Now about 70 donations have been created by draft donation service and got verified, four TXs that you already said 3 of them have been added but the fourth one has not matched yet, so this problem is almost fixed, but not 100%, I'm still working

@laurenluz
Copy link
Member

@mohammadranjbarz when you merge this today, all the missed donations should be considered, right? wondering because GIvbacks and QF data analysis are blocked 😅

@mohammadranjbarz
Copy link
Collaborator

@mohammadranjbarz when you merge this today, all the missed donations should be considered, right? wondering because GIvbacks and QF data analysis are blocked 😅

Yess, I just need to check the recurring donations streams, it would work but I need to check the documents in the DB

@laurenluz
Copy link
Member

what's the status on this?

@jainkrati
Copy link
Collaborator

@maryjaf to confirm if this is working on staging.

@maryjaf
Copy link
Collaborator

maryjaf commented May 22, 2024

@maryjaf to confirm if this is working on staging.

my missing donation to https://giveth.io/project/commons-stackproject on 6 May, have been added correctly
but for other donations for any users, I don't know how can I check @mohammadranjbarz

@divine-comedian
Copy link
Collaborator Author

divine-comedian commented May 22, 2024

There is just one transaction I referenced here that needs to be added manually since it didn't appear caught in any service
#1580

@jainkrati
Copy link
Collaborator

@CarlosQ96 can you pls take this up as @mohammadranjbarz is not well.

@divine-comedian
Copy link
Collaborator Author

divine-comedian commented May 29, 2024

Mohammad added in manually the one missing transaction, we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants