FIx/Verify email banner on other user account

[kkatusic]

• Visiting user public page tells me to verify my email #4954

Summary by CodeRabbit

• Bug Fixes
  • Improved email verification banner rendering logic to ensure it only displays when user account is active and email is unverified.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
giveth-dapps-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 21, 2025 11:20am

[coderabbitai]

Walkthrough

The pull request modifies the rendering logic of the VerifyEmailBanner component within the UserProfileView. The change updates the conditional rendering to require both the existence of a user object and the myAccount variable being true, in addition to the user's email being unverified. This refinement ensures more precise control over when the verification banner is displayed, potentially improving the user interface's conditional rendering behavior.

Changes

File	Change Summary
src/components/views/userProfile/UserProfile.view.tsx	Updated conditional rendering of VerifyEmailBanner to check for user object, myAccount status, and email verification state

Possibly related PRs

• Applying new style and fixing timeout #4940: Modifies InputUserEmailVerify component, focusing on email verification process control flow

Suggested reviewers

• CarlosQ96

Poem

🐰 A banner's dance, a logic's grace,
Conditions checked with rabbit's pace
User, account, and email's might
Render true when all align just right!
Code hops with precision, clear and bright 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/views/userProfile/UserProfile.view.tsx (1)

127-129: LGTM! The conditional rendering fix looks good.

The updated condition correctly ensures the email verification banner only appears on the user's own profile when their email is unverified. This fixes the issue of the banner showing up on other users' profiles.

For additional type safety, consider using the optional chaining operator consistently:

-{user && myAccount && !user?.isEmailVerified && (
+{user?.isEmailVerified === false && myAccount && (

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 73c3958 and 055dec5.

📒 Files selected for processing (1)

• src/components/views/userProfile/UserProfile.view.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build