Setting Page - to enable/disable notifs on different channels

[MoeNick]

Design resource

Important: General setting is not a tab and users can't close it!

Notification settings / Default -> Figma link
In the default state, all tabs are closed.

Notification settings / Project activities - > Figma link

Notification settings / GIVeconomy settings -> Figma link

---

[mosaeedi]

@Tosinolawale Maybe we can handle it in the Notification center!?

[Tosinolawale]

Yeah we can. I will just resolve it on Notification settings

[MoeNick]

Let's finalize it @Tosinolawale , shall we start next week ?

[Tosinolawale]

Started work on this currently. Will have something for you tomorrow

[MoeNick]

@MoeNick to sync frontend and backedn together.
@CarlosQ96 would you pls snd the related endpoints here.

[CarlosQ96]

Hey @MohammadPCh @alireza-sharifpour @RamRamez
This are the docs for the staging backend: https://staging.notification.giveth.io/docs

Here are the endpoints:

1. GET https://staging.notification.giveth.io/v1/notification_settings
   • Retrieves User notifications
   • Query Params: limit, offset, category
   • Category is optional for extra filtering, but posible values are: general, projectRelated, givEconomy
   • Only General and projectRelated are available, there is no givEconomy yet.
   • This returns:

{
  "count": 0,
  "notificationSettings": [
    {
      "id": 0,
      "isGlobalSetting": true,
      "allowNotifications": true,
      "allowEmailNotification": true,
      "allowDappPushNotification": true,
      "notificationType": {
        "id": 0,
        "microService": "string",
        "name": "string",
        "description": "string",
        "schemaValidator": "string",
        "category": "string",
        "emailNotifierService": "string",
        "emailNotificationId": "string",
        "pushNotifierService": "string",
        "requiresTemplate": true,
        "htmlTemplate": "string",
        "title": "string",
        "content": "string",
        "notificationSettings": [
          "string"
        ],
        "createdAt": "2022-09-13T14:48:14.664Z",
        "updatedAt": "2022-09-13T14:48:14.664Z"
      },
      ........ etc
   ]
}

2. PUT https://staging.notification.giveth.io/v1/notification_settings/:id
   • Updates a given notification by id
   • Body Params: Id, allowNotifications, allowEmailNotification, allowDappPushNotification
   • The allow notifications body params are strings (true or false)
   • This returns:

{
  "id": 0,
  "isGlobalSetting": true,
  "allowNotifications": true,
  "allowEmailNotification": true,
  "allowDappPushNotification": true,
  "notificationType": {
    "id": 0,
    "microService": "string",
    "name": "string",
    "description": "string",
    "schemaValidator": "string",
    "category": "string",
    "emailNotifierService": "string",
    "emailNotificationId": "string",
    "pushNotifierService": "string",
    "requiresTemplate": true,
    "htmlTemplate": "string",
    "title": "string",
    "content": "string",
    "notificationSettings": [
      "string"
    ],
    "createdAt": "2022-09-13T14:48:14.655Z",
    "updatedAt": "2022-09-13T14:48:14.655Z"
  },
  "notificationTypeId": 0,
  "userAddress": {
    "id": 0,
    "walletAddress": "string",
  }
}

[MohammadPCh]

Thanks @CarlosQ96

[MoeNick]

Hey @CarlosQ96
As per discussed, can you also relate them here, so I have clue about how can I work on the product side with @mosaeedi ?
https://docs.google.com/spreadsheets/d/1VMsmF9oJEwf1JyNEAfWi2n2eYvG6ZtnkXKB_3Hv29x8/edit#gid=0

[maryjaf]

In "Notification settings / Project activities" figma, verification status is not shown in Notification settings, the notification is not sent after verify or un-verify project from admin panel? @MoeNick

[maryjaf]

I staked and got rewarded but i didn't receive any notification about these, even though they are active in the setting @RamRamez @mohammadranjbarz

[RamRamez]

I staked and got rewarded but i didn't receive any notification about these, even though they are active in the setting @RamRamez @mohammadranjbarz

@CarlosQ96 I use typeId 59 and 60 for these settings. Are they correct?

[CarlosQ96]

They are correct, but please hold-on on the testing of giveconomy notifications this logic does not exist yet. We have to write a service that listens to a new subgraph for live-changes. That’s a lot of work and is not yet done.

[CarlosQ96]

Right now we are migrating sending emails from impact graph backend to the Notification Center backend. So some notifications might send emails right now even when you disable it.

After Mohammad migrates that part. We will move on to giveconomy notifications implementation but it’s on planning stages.

[CarlosQ96]

@maryjaf @RamRamez

[CarlosQ96]

Right now giveconomy notifications settings mostly change the Boolean value of the database.

[CarlosQ96]

So you can mostly check if the checkmark persist when disabling or enabling.

[maryjaf]

Right now we are migrating sending emails from impact graph backend to the Notification Center backend. So some notifications might send emails right now even when you disable it.

After Mohammad migrates that part. We will move on to GIVeconomy notifications implementation but it’s on planning stages.

Thanks
So now this issue is blocked and the test cannot be completed? @CarlosQ96 @MoeNick
Can you please send the link of this issue?

[maryjaf]

In "Notification settings / Project activities" figma, verification status is not shown in Notification settings, the notification is not sent after verify or un-verify project from admin panel? @MoeNick

I tested, the notification is sent after verify or un-verify project, but this verification item is not mentioned in the project activities. @MoeNick

[maryjaf]

Figma and test environment are different @RamRamez
Is it okay that both items have the same title? @mosaeedi

[RamRamez]

Figma and test environment are different @RamRamez Is it okay that both items have the same title? @mosaeedi

Yeah, @MoeNick added two new rows.

[maryjaf]

Figma and test environment are different @RamRamez Is it okay that both items have the same title? @mosaeedi

Yeah, @MoeNick added two new rows.

Yeah, but Is it okay that both items have the same title? @MoeNick

[laurenluz]

If we make too many redundant notifications the notifications won't have value because people won't check them. @aminlatifi @MoeNick

[aminlatifi]

@laurenluz I agree, let's focus on actions happening in the background. Like givpower unlock and givback payments.

[laurenluz]

Yes!! @aminlatifi

[maryjaf]

So, notifying the user after the stake/unstake should also be removed?
In this case, the page related to the notification setting of Giveconomy should also be changed @MoeNick
Please let me know if the frond and backend changes have been done and I will test again

[mohammadranjbarz]

@maryjaf I changed the titles of Notification setting items based on what moenick had said

@aminlatifi @maryjaf I removed Stakes item from notification setting items

[maryjaf]

@aminlatifi @maryjaf I removed Stakes item from notification setting items

Based on the discussions, I think that this item also should be removed

because in the lock scenario that was mentioned above, the correct notification was not received.
And I don't receive notifications for Harvest and Givback & boost , have these not been implemented? @mohammadranjbarz @aminlatifi

[maryjaf]

@maryjaf I changed the titles of Notification setting items based on what moenick had said

Thanks @mohammadranjbarz I checked and it passed

[laurenluz]

I think it is good to tell people when their GIV gets unlocked (and their GIVpower balancr goes down).

Do we have this notification @mohammadranjbarz @maryjaf

[maryjaf]

I think it is good to tell people when their GIV gets unlocked (and their GIVpower balancr goes down).

Do we have this notification @mohammadranjbarz @maryjaf

I didn't receive notification about that

[maryjaf]

based on this change( #1947 (comment))
I checked my notification and I received unlock notification in "all " tab but i didn't see these on Giveconomy tab in notification setting


@aminlatifi @mohammadranjbarz

[aminlatifi]

based on this change( #1947 (comment)) I checked my notification and I received unlock notification in "all " tab but i didn't see these on Giveconomy tab in notification setting @aminlatifi @mohammadranjbarz

@maryjaf It must be fixed now

[maryjaf]

based on this change( #1947 (comment)) I checked my notification and I received unlock notification in "all " tab but i didn't see these on Giveconomy tab in notification setting @aminlatifi @mohammadranjbarz

@maryjaf It must be fixed now

Thanks @aminlatifi I Checked again now the unlock notification are shown in Giveconomy tab

[maryjaf]

I think these three items are open from the notification center @aminlatifi @mohammadranjbarz
1- I don't receive a notification when I boost a project or someone boosts my project

2- The same for give back and harvest

3- Based on the discussions, it was decided not to send a notification to Lock, and in this case, it is necessary to change the text below. @MoeNick

And one question: Will we not send notifications for stake and unstake from now?

[mohammadranjbarz]

@MoeNick @maryjaf @laurenluz

We dont trigger notification for this item

If we want it please make an issue for that to start implementing that, otherwise we can remove it from setting page

[MoeNick]

@MoeNick @maryjaf @laurenluz

We dont trigger notification for this item

If we want it please make an issue for that to start implementing that, otherwise we can remove it from setting page

No, we don't want to have it.

We only have to add these:
1- Boost event for the project manager. (in projects section, not give economy section)
2- Token unlocked for the user.
3- GIVbacks for the users.

[mohammadranjbarz]

@MoeNick @maryjaf @laurenluz
We dont trigger notification for this item
If we want it please make an issue for that to start implementing that, otherwise we can remove it from setting page

No, we don't want to have it.

We only have to add these: 1- Boost event for the project manager. (in projects section, not give economy section) 2- Token unlocked for the user. 3- GIVbacks for the users.

Nice, please give me the titles and descriptions for these three items that you already mentioned

[maryjaf]

I think these three items are open from the notification center @aminlatifi @mohammadranjbarz 1- I don't receive a notification when I boost a project or someone boosts my project

2- The same for give back and harvest

3- Based on the discussions, it was decided not to send a notification to Lock, and in this case, it is necessary to change the text below. @MoeNick

And one question: Will we not send notifications for stake and unstake from now?

The last update of testing notification

I receive notification for Givback correctly

when some one boost my project for first time I receive notification

@MoeNick @aminlatifi @mohammadranjbarz

[maryjaf]

The display order of project activities items for some accounts is changed by changing the setting (send email and notification)
The exact scenario is not clear yet
Plz check this @RamRamez @mohammadranjbarz
account:0xD5db3F8B0a236176587460dC85F0fC5705D78477

account:0xA1179f64638adb613DDAAc32D918EB6BEB824104

[mohammadranjbarz]

The display order of project activities items for some accounts is changed by changing the setting (send email and notification) The exact scenario is not clear yet Plz check this @RamRamez @mohammadranjbarz account:0xD5db3F8B0a236176587460dC85F0fC5705D78477 account:0xA1179f64638adb613DDAAc32D918EB6BEB824104

@maryjaf Can you please test it again?

[maryjaf]

Thanks @mohammadranjbarz it has been fixed

[maryjaf]

We can move this issue to Done after final changes of this page are deployed and tested