GIVbacks page changes corresponding to new GIVbacks changes - on prod by Sept 16

[laurenluz]

Starting on September 17, we will have a minimum $5 donation requirement for GIVbacks eligibility, plus we are experimenting with the raffle & with decentralized verification, here are some changes I think we can/should make:

GIVbacks Page

• givbacks page, title subtext: "When you make a donation of $5 or more to a GIVbacks eligible project you qualify to get GIV!"
  

• givbacks page, remove all this:
  

• Change "GIV Allocated to Round" to "GIVbacks Rewards"
  

• Change hard coded 1 Million GIV to a dynamic number from Show GIVbacks rewards amount available in the round SO FAR - backend changes #4678 (if possible)

• Change GIVbacks box copy title "When you give you get GIV back!" to "Give and get GIV back!"
  

• Change GIVbacks box copy subtext to: "Each GIVbacks round lasts two weeks. The GIVbacks Rewards available depends on the amount donated at in the round, to a maximum amount of 1 million GIV. After the End Date, the GIVbacks Rewards for the round go to the eligible donors."
  

• Comment out "why don't I have GIVbacks" part and corresponding modal
  

@mohammadranjbarz can you assign the right person?

[laurenluz]

cc @WhyldWanderer

[mohammadranjbarz]

@maryjaf @laurenluz Can you check the preview link https://giveth-dapps-v2-git-4679modifygivbackchangetobe-210dfd-givethio.vercel.app/givbacks

When for any reason FE request fails and can't get the result, or it is zero I show ? is it ok?

@maryjaf As we have 1 hour cache you can't check it in FE to see if it works properly or not, so it's better to test webservice

curl --location 'https://impact-graph.serve.giveth.io/graphql' \
--header 'Content-Type: application/json' \
--data '{"query":"query {\n    allocatedGivbacks(\n        refreshCache:true\n    ){\n            usdValueSentAmountInPowerRound\n            allocatedGivTokens\n            givPrice\n            date\n    }\n}","variables":{}}'

And send refreshCache:true to get updated result

[laurenluz]

hmmm it's showing me "?" right now - is it likely the FE request is failing right now? or it's more likely that it's because the value is 0?

ideally, we should the last updated GIVbacks pool amount until the FE can get the new value... so if last time it was working the GIVbacks pools size is 50,000 GIV, we should that, rather than "?"

If it's the start of a new round though perhaps, and the amount is actually 0.. let's show "TBD"

[maryjaf]

Thanks @mohammadranjbarz The copy fixes has been applied correctly on feature branch
but for testing the web service I have a question

By donating on staging, the "allocatedGivTokens" in response of api should be increased?
{
"data": {
"allocatedGivbacks": {
"usdValueSentAmountInPowerRound": 0,
"allocatedGivTokens": 0,
"givPrice": 0.00584277,
"date": "2024-09-15T07:45:17.709Z"
}
}
}

[mohammadranjbarz]

Thanks @mohammadranjbarz The copy fixes has been applied correctly on feature branch but for testing the web service I have a question

By donating on staging, the "allocatedGivTokens" in response of api should be increased? { "data": { "allocatedGivbacks": { "usdValueSentAmountInPowerRound": 0, "allocatedGivTokens": 0, "givPrice": 0.00584277, "date": "2024-09-15T07:45:17.709Z" } } }

@maryjaf If project is givback eligible, token is givback eligible and donor address is not in the purple list, yes it would be increased

[maryjaf]

Thanks @mohammadranjbarz could you please tell me more about the formula of increasing GIV for givback

This is the result of my test but i'm not sure if it's correct or not

I Donated 0.001 xdai
https://gnosisscan.io/tx/0x3bdbe85fc92eb5fc4ac573a5d6e97c3e39baf09d9daea8d47a691fe0e93e4ab2
Response :
{
"data": {
"allocatedGivbacks": {
"usdValueSentAmountInPowerRound": 0.00078181823,
"allocatedGivTokens": 1,
"givPrice": 0.00584277,
"date": "2024-09-15T14:05:05.995Z"
}
}
}

---

I Donated 0.01 xdai
https://gnosisscan.io/tx/0x286c4b93384b7ec0473d7ee89e31bbefb83faf28e9b2184c5a9cd6ca0c5e4329
Response :

{
"data": {
"allocatedGivbacks": {
"usdValueSentAmountInPowerRound": 0.0086,
"allocatedGivTokens": 2,
"givPrice": 0.00584277,
"date": "2024-09-15T14:08:15.953Z"
}
}
}

---

I donate 100GIV on OP sepolia(1 GIV=1$)
https://optimism-sepolia.blockscout.com/tx/0xdd583ecc27038822018d2cb5091343517008241d475fbff2deecb795845cd1ac
Response:

{
"data": {
"allocatedGivbacks": {
"usdValueSentAmountInPowerRound": 60.909092,
"allocatedGivTokens": 10425,
"givPrice": 0.00584277,
"date": "2024-09-15T14:35:35.531Z"
}
}
}

[mohammadranjbarz]

Thanks @mohammadranjbarz could you please tell me more about the formula of increasing GIV for givback

This is the result of my test but i'm not sure if it's correct or not

I Donated 0.001 xdai https://gnosisscan.io/tx/0x3bdbe85fc92eb5fc4ac573a5d6e97c3e39baf09d9daea8d47a691fe0e93e4ab2 Response : { "data": { "allocatedGivbacks": { "usdValueSentAmountInPowerRound": 0.00078181823, "allocatedGivTokens": 1, "givPrice": 0.00584277, "date": "2024-09-15T14:05:05.995Z" } } }

I Donated 0.01 xdai https://gnosisscan.io/tx/0x286c4b93384b7ec0473d7ee89e31bbefb83faf28e9b2184c5a9cd6ca0c5e4329 Response :

{ "data": { "allocatedGivbacks": { "usdValueSentAmountInPowerRound": 0.0086, "allocatedGivTokens": 2, "givPrice": 0.00584277, "date": "2024-09-15T14:08:15.953Z" } } }

I donate 100GIV on OP sepolia(1 GIV=1$) https://optimism-sepolia.blockscout.com/tx/0xdd583ecc27038822018d2cb5091343517008241d475fbff2deecb795845cd1ac Response:

{ "data": { "allocatedGivbacks": { "usdValueSentAmountInPowerRound": 60.909092, "allocatedGivTokens": 10425, "givPrice": 0.00584277, "date": "2024-09-15T14:35:35.531Z" } } }

@maryjaf We just calculate the value USD amount in the round, get GIV price from coingecko, then divide the USD amount value to GIV price and it is the allocatedGivTokens in the round so far.

[maryjaf]

hmmm it's showing me "?" right now - is it likely the FE request is failing right now? or it's more likely that it's because the value is 0?

ideally, we should the last updated GIVbacks pool amount until the FE can get the new value... so if last time it was working the GIVbacks pools size is 50,000 GIV, we should that, rather than "?"

If it's the start of a new round though perhaps, and the amount is actually 0.. let's show "TBD"

Thanks @mohammadranjbarz it seems the calculation is correct based on above formula.

Only this item remains, showing ? for "GIVbacks Rewards" on this branch https://giveth-dapps-v2-git-4679modifygivbackchangetobe-210dfd-givethio.vercel.app/givbacks

[mohammadranjbarz]

@maryjaf can you test it on this link https://giveth-dapps-v2-b4iwwt02n-givethio.vercel.app ?

[maryjaf]

If it's the start of a new round though perhaps, and the amount is actually 0.. let's show "TBD"

Since it isn't the start of new round and there are some donations on staging, is TBD right? @mohammadranjbarz

[mohammadranjbarz]

If it's the start of a new round though perhaps, and the amount is actually 0.. let's show "TBD"

Since it isn't the start of new round and there are some donations on staging, is TBD right? @mohammadranjbarz

It shows correctly for me

[maryjaf]

Thanks @mohammadranjbarz now it is shown for me correctly