Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project was successfully completed but the notification makes it seem like it was in violation #2305

Closed
WhyldWanderer opened this issue Mar 7, 2023 · 12 comments

Comments

@WhyldWanderer
Copy link

This is very off-putting as this project has been deactivated and unlisted because it completed its mission successfully and no longer needs funding. This message makes it seem like the project was in violation of something when really its just finished.

image

@WhyldWanderer WhyldWanderer changed the title User Story Project was successfully completed but the notification makes it seem like it was in violation Mar 7, 2023
@NikolaCreatrix
Copy link

Yeah, I also noticed.... maybe we need one more simple button that will say - mission complete! (that would just deactivate and archive the project automatically without performing the unlist notification... And the notification center will say something like - "This project has reached its goal and has been deactivated. Let's celebrate the impact you made!"

Is that any possible option?

@MoeNick
Copy link
Member

MoeNick commented Mar 7, 2023

I think the copy is not suitable, unlisting means not been searchable or list, its not necessarily related to listing guidance.

Completing is another feature,we do not have this concept in Giveth, projects are not time-limited, or fund limited. Lets not mix completing with diactivating.

@WhyldWanderer
Copy link
Author

I also received this one today... it means that anytime the project makes an edit or adds an update the user will be notified. It just seems unnecessary to notify the user EVERY time the project becomes relisted after review.. Sometimes this happens multiple times in one day if the project is newer.

Maybe we should consider not sending notifications for listing or unlisting as it is an internal thing...
image

@laurenluz
Copy link
Member

laurenluz commented Mar 20, 2023

ok, from the feedback above, we should:

  • never send notifications to the project supporters when a project they supported is listed or unlisted @mohammadranjbarz
  • hide/remove this section from the notification settings
    image

Also - is there somewhere I can see the copy we have for the notifications to project owners for when their project is listed/unlisted? Ideally, we can make it simple, so something like:

  • Change copy on notifications to project owner when project gets listed to "Your project < project name > has been listed on the projects page."
  • Change copy on notifications to project owner when project gets unlisted to "Your project < project name > has been unlisted from the projects page."

Is that ok @WhyldWanderer ?

@WhyldWanderer
Copy link
Author

Looks great to me.. Thanks for this Lauren!

@MoeNick MoeNick added the bug Something isn't working label May 15, 2023
@divine-comedian
Copy link
Contributor

@mohammadranjbarz is this clear? can you check this out?

@mohammadranjbarz
Copy link
Contributor

ok, from the feedback above, we should:

  • never send notifications to the project supporters when a project they supported is listed or unlisted @mohammadranjbarz
  • hide/remove this section from the notification settings
    image

Also - is there somewhere I can see the copy we have for the notifications to project owners for when their project is listed/unlisted? Ideally, we can make it simple, so something like:

  • Change copy on notifications to project owner when project gets listed to "Your project < project name > has been listed on the projects page."
  • Change copy on notifications to project owner when project gets unlisted to "Your project < project name > has been unlisted from the projects page."

Is that ok @WhyldWanderer ?

Woow sorry I hadn't seen this issue.
@divine-comedian yeah its clear to me

@MoeNick
Copy link
Member

MoeNick commented Aug 21, 2023

@mohammadranjbarz can you take the last 2 text changes?

@mohammadranjbarz
Copy link
Contributor

@maryjaf
It's on staging, you can test it now

@maryjaf
It's on staging, you can test it now

@maryjaf maryjaf removed the bug Something isn't working label Aug 24, 2023
@maryjaf
Copy link
Collaborator

maryjaf commented Aug 24, 2023

  • never send notifications to the project supporters when a project they supported is listed or unlisted @mohammadranjbarz

When a project has been listed/unlisted, the notification is sent for project supporter , should this notification be removed? @MoeNick @mohammadranjbarz

Unlist:
my project :
Your project MAYAMAYATEST has been unlisted from the projects page.
supported projects:
MAYAMAYATEST did not meet our guidelines for listed projects and has been hidden from the projects page.

List:
my project :
Your project MAYAMAYATEST has been listed on the projects page.

supported projects:
MAYAMAYATEST is now listed on the Giveth projects page.

@mohammadranjbarz
Copy link
Contributor

  • never send notifications to the project supporters when a project they supported is listed or unlisted @mohammadranjbarz

When a project has been listed/unlisted, the notification is sent for project supporter , should this notification be removed? @MoeNick @mohammadranjbarz

Unlist: my project : Your project MAYAMAYATEST has been unlisted from the projects page. supported projects: MAYAMAYATEST did not meet our guidelines for listed projects and has been hidden from the projects page.

List: my project : Your project MAYAMAYATEST has been listed on the projects page.

supported projects: MAYAMAYATEST is now listed on the Giveth projects page.

@MoeNick mentioned for this step we just need to implement those two change copy items in list of tasks
#2305 (comment)

@divine-comedian
Copy link
Contributor

Yes the other two items imply more effort - we can deal with them later

@MoeNick MoeNick closed this as completed Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants