-
-
Notifications
You must be signed in to change notification settings - Fork 397
Isolate logic surrounding ls-refs command #2242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d57d61d to
31414e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
This is wonderful and thanks to my additional refactor I think I am also restoring my feeling for this part of the codebase, a part that I have neglected quite a bit, and the happier I am that you are doing this work!
|
And I forgot to mention: please use the conventional commit prefixes sparingly, particularly with |
Rejiggers the code surrouding the
ls-refspart of gix-protocol to split pre- and post-transport logic from the core networking logic, with the goal of avoiding code duplication for blocking/async I/O down the line.