Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to GIT_HIGHEST_SCOPE_CONFIG_PATH #1569

Merged
merged 1 commit into from
Aug 31, 2024

Commits on Aug 31, 2024

  1. Rename to GIT_HIGHEST_SCOPE_CONFIG_PATH

    This renames the crate-internal static item with the cached path
    of the highest scope nonempty config, treated as associated with
    the `git` installation, from `GIT_HIGHEST_PRIORITY_CONFIG_PATH` to
    `GIT_HIGHEST_SCOPE_CONFIG_PATH`.
    
    This reflects the propensity of "priority" to have the opposite of
    the intended meaning here, since configuration in this file stands
    to be superseded by configuration in any lower (i.e. any other)
    scope. See GitoxideLabs#1568 for context.
    
    I think this change from "PRIORITY" to "SCOPE" in the name
    preserves the benefits of the change from `EXE_INFO` to
    `GIT_HIGHEST_PRIORITY_CONFIG_PATH` (dd2d666), while making clearer
    what is going on and avoiding misinterpretations.
    EliahKagan committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    0672576 View commit details
    Browse the repository at this point in the history