Skip to content

fix(atlas-cloud): sync static catalog with live /models metadata - #1754

Merged
kevincodex1 merged 1 commit into
Twigpine:mainfrom
jatmn:atlascloude
Jun 23, 2026
Merged

kevincodex1 merged 1 commit into
Twigpine:mainfrom
jatmn:atlascloude

Conversation

@jatmn

@jatmn jatmn commented Jun 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Updated the Atlas Cloud static vendor catalog (src/integrations/vendors/atlas-cloud.ts) to match the current live /v1/models response from https://api.atlascloud.ai.

  • Enriched every static entry with maxOutputTokens (sourced from live max_output_length) and capabilities (function calling, JSON mode, vision, reasoning).
  • Added per-model transportOverrides.openaiShim.removeBodyFields for xai/grok-build-0.1 (drops reasoning_effort to prevent 400s).
  • Curated current model set:
    • Added: Kimi K2.7 Code, GLM 5.2, Qwen3.7 Max/Plus + recent Qwen variants, Doubao Seed 2.0 variants, Claude Sonnet 4.6 / Haiku 4.5 (including coding variants), latest GPT/Gemini/Grok.
    • Removed: deprecated K2 Thinking/Instruct 0905, older MiniMax M2.1/M2, and some duplicates.
  • Entries remain in descending version order within each vendor family.
  • Preserved notes: 'Free' on the owl model.
  • .gitignore: added .tmp-* to cover ephemeral test artifact directories (e.g., replay index tests).

This keeps the catalog as pure source: 'static' (per project preference) and compensates for metadata that toDiscoveredModelEntry drops.

Motivation / Impact

  • Live catalog has drifted significantly from the previously committed static set.
  • Users selecting Atlas Cloud models now see accurate context/output limits and capability tags in UI and recommendations.
  • Fixes hard failure for Grok Build 0.1 on this provider.
  • Prevents accidental use of outdated model IDs.
  • Small hygiene win: stops test temp dirs from appearing in git status.

Provider path tested: Atlas Cloud (OpenAI-compatible, base https://api.atlascloud.ai/v1).

Checks run (exact commands)

bun install
bun run build
bun run smoke
bun run check
bun run typecheck
bun run typecheck:type-tests
bun run test:provider
bun run test:provider-recommendation
bun run integrations:check
bun run doctor:runtime
bun run scripts/pr-intent-scan.ts --base upstream/main --head HEAD

All passed cleanly. bun run check (smoke + deadcode + full test suite at concurrency 1) was green. Provider tests (872) and recommendation tests (92) passed. integrations:check confirmed generated artifacts are in sync. doctor:runtime successfully reached the live Atlas Cloud /models endpoint. PR intent scan reported no suspicious additions against upstream/main merge-base.

No UI changes, no new runtime dependencies, no Python changes. Follows AGENTS.md + CONTRIBUTING.md provider change guidelines (static catalog only, documented overrides, exact path tested).

Scope notes

  • Only touches Atlas Cloud vendor definition and gitignore for test artifacts.
  • No provider tag changes (controlled by maintainers).
  • No broad refactors or unrelated cleanups.

Summary by CodeRabbit

  • Chores

    • Updated version control settings to ignore additional temporary files and folders.
  • New Features

    • Enhanced Atlas Cloud integration with a refreshed model catalog.
    • Added richer per-model metadata such as token limits and capabilities to improve visibility into supported features (e.g., structured output, tool use, vision, and related options).

@coderabbitai

coderabbitai Bot commented Jun 23, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 737a901b-6d77-48cd-a83c-0b2892a35fe3

📥 Commits

Reviewing files that changed from the base of the PR and between 04923a2 and fb4df66.

📒 Files selected for processing (2)
  • .gitignore
  • src/integrations/vendors/atlas-cloud.ts
📜 Recent review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: typecheck
  • GitHub Check: smoke-and-tests
🧰 Additional context used
📓 Path-based instructions (9)
src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Use TypeScript with strict mode and ESM imports

Files:

  • src/integrations/vendors/atlas-cloud.ts
{src/integrations/**/*.ts,src/services/**/*.ts}

📄 CodeRabbit inference engine (AGENTS.md)

Test the exact provider/model path you changed when possible for provider modifications

Files:

  • src/integrations/vendors/atlas-cloud.ts
src/integrations/**/*.ts

📄 CodeRabbit inference engine (AGENTS.md)

Check existing provider implementations before adding a new pattern

Files:

  • src/integrations/vendors/atlas-cloud.ts
**/*.{ts,tsx,js,jsx,py,json,md}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Follow the existing code style in the touched files

Files:

  • src/integrations/vendors/atlas-cloud.ts
**/*.{ts,tsx,js,jsx,py}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Keep comments useful and concise

Files:

  • src/integrations/vendors/atlas-cloud.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Follow TypeScript strict mode and type safety practices by running typecheck before submitting

Files:

  • src/integrations/vendors/atlas-cloud.ts
**

⚙️ CodeRabbit configuration file

**: # AGENTS.md - AI Agent Coding Guide

This guide is for AI coding agents working in the OpenClaude repository. Read it before changing code, and also follow CONTRIBUTING.md for contributor policy, PR expectations, review follow-up, and project scope.

Project Snapshot

OpenClaude is a coding-agent CLI for cloud and local model providers. It supports OpenAI-compatible APIs, Anthropic, Gemini, DeepSeek, Ollama, MCP, local backends, slash commands, tools, agents, and a React/Ink terminal UI.

The installed CLI runs on Node.js >=22.0.0. Bun is used for source builds, scripts, dependency management, and tests.

Work Style

  • Keep changes focused on one problem.
  • Prefer existing patterns in the file or nearby module.
  • Avoid unrelated formatting, renames, dependency changes, or broad rewrites.
  • Add or update tests when behavior changes.
  • Update docs when setup, commands, provider behavior, or user-facing behavior changes.
  • For new features, larger refactors, dependencies, or runtime changes, follow the issue-first guidance in CONTRIBUTING.md.

Stack And Conventions

  • TypeScript with strict mode and ESM imports.
  • React + Ink for terminal UI.
  • Bun lockfile and Bun scripts for development workflows.
  • Node runtime for the built CLI.
  • Python exists for legacy/local-provider helper code. Do not add new Python code or expand Python-based features unless a maintainer explicitly approves that direction.

Common libraries and patterns:

  • chalk for terminal color.
  • commander for CLI argument parsing.
  • execa for child processes.
  • Existing service, provider, settings, permission, and UI patterns over new abstractions.

Repository Map

  • src/commands/ - slash and CLI command implementations.
  • src/components/ - React/Ink UI components.
  • src/services/ - API, MCP, OAuth, wiki, voice, and other service integrations.
  • src/tools/ - tool implementations.
  • src/utils/ - shared utilities.
  • `src/integration...

Files:

  • src/integrations/vendors/atlas-cloud.ts
**/*

⚙️ CodeRabbit configuration file

**/*: Apply the OpenClaude maintainer review rubric from AGENTS.md. Review the current diff, not stale discussion context. Separate real blockers from suggestions. Do not request changes for vague style churn. Treat approval as merge-ready from CodeRabbit's side, pending required human review and GitHub Checks. If checks are failing or unavailable, say so clearly instead of implying the PR is fully ready.

Files:

  • src/integrations/vendors/atlas-cloud.ts
{src/services/api/**,src/integrations/**,src/utils/model/**,src/utils/provider*.ts,src/commands/provider/**}

⚙️ CodeRabbit configuration file

{src/services/api/**,src/integrations/**,src/utils/model/**,src/utils/provider*.ts,src/commands/provider/**}: Review provider routing, model selection, env precedence, auth/token handling, OpenAI-compatible shims, retries, proxy behavior, and outbound HTTP behavior with high scrutiny. Block on silent default changes, hidden fallback expansion, credential reuse mistakes, hardcoded provider assumptions, or new network reach that is not intentional and documented.

Files:

  • src/integrations/vendors/atlas-cloud.ts
🔇 Additional comments (2)
.gitignore (1)

26-26: LGTM!

src/integrations/vendors/atlas-cloud.ts (1)

38-89: LGTM!


📝 Walkthrough

Walkthrough

The Atlas Cloud vendor's static model catalog in atlas-cloud.ts is refreshed with enriched per-model metadata: entries now include maxOutputTokens, capabilities (function-calling, JSON mode, vision, reasoning), and occasional transportOverrides/notes. The model ID set is updated by removing several existing entries and adding new ones. .gitignore gains a .tmp-* wildcard pattern.

Changes

Atlas Cloud catalog update and gitignore refresh

Layer / File(s) Summary
Atlas Cloud static model catalog refresh
src/integrations/vendors/atlas-cloud.ts
catalog.models entries are replaced with updated model IDs and enriched metadata: maxOutputTokens, structured capabilities (function-calling, JSON mode, vision, reasoning), transportOverrides (e.g., Grok Build's reasoning_effort removal), and notes. Several model IDs are removed; new ones are added.
Build artifact cleanup pattern
.gitignore
Adds .tmp-* pattern to ignore files and directories prefixed with .tmp-.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • Gitlawb/openclaude#1755: Overlaps with the main PR's Atlas Cloud vendor catalog refresh in src/integrations/vendors/atlas-cloud.ts since both directly modify the catalog.models array.
🚥 Pre-merge checks | ✅ 6 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Risk Surface Disclosed ⚠️ Warning PR touches provider routing (transportOverrides.openaiShim.removeBodyFields for grok-build-0.1), but review comments addressed only merge conflicts, not this risk surface. Review should document assessment of the transportOverrides change and confirm whether it blocks merge or is safe to proceed.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: syncing the Atlas Cloud static catalog with live metadata.
Description check ✅ Passed The description fully covers all required template sections with comprehensive detail: summary, impact, testing checklist completion, and notes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No Hidden Policy Change ✅ Passed PR only updates Atlas Cloud catalog metadata (models list, maxOutputTokens, capabilities) and adds .tmp-* to .gitignore. No hidden product, trust-model, routing-default, telemetry/network, or permi...

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 23, 2026
@jatmn
jatmn marked this pull request as ready for review June 23, 2026 01:54
@jatmn

jatmn commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

@kevincodex1 this one is ready to go.

@jatmn jatmn self-assigned this Jun 23, 2026
@jatmn jatmn added new: provider/gateway Request to add a new provider or gateway enhancement New feature or request and removed new: provider/gateway Request to add a new provider or gateway labels Jun 23, 2026
@kevincodex1

Copy link
Copy Markdown
Member

hey bro please fix conflicts

@jatmn

jatmn commented Jun 23, 2026 •

Copy link
Copy Markdown
Collaborator Author

hey bro please fix conflicts

I cant the conflict is to directly reverse changes of #1755 , it would be best to unmerge that pr as this directly replaces work done by that pr.

- Enrich every entry with maxOutputTokens (from max_output_length) and
  capabilities (function calling, json mode, vision, reasoning) pulled from
  the live catalog. Addresses discoveryService metadata gap.
- Add transportOverrides.openaiShim.removeBodyFields for xai/grok-build-0.1
  to drop reasoning_effort (fixes 400 on Atlas Cloud).
- Curate current model set:
  - Add: Kimi K2.7 Code, GLM 5.2, Qwen3.7 Max/Plus, Doubao Seed 2.0 variants,
    Claude Sonnet 4.6 / Haiku 4.5 (base + coding), latest GPT/Gemini/Grok.
  - Drop: K2 Thinking/Instruct 0905, older MiniMax M2.1/M2, duplicate Qwen.
- Keep source: 'static' only. Entries sorted in descending version order
  within each vendor family.
- Preserve notes: 'Free' on the owl model.

.gitignore: ignore .tmp-* directories (test artifacts such as replay-index tests).

Follows static-over-hybrid, catalog-model-ordering, and grok-build-0.1 notes.
@jatmn

jatmn commented Jun 23, 2026 •

Copy link
Copy Markdown
Collaborator Author

@kevincodex1 please merge asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants