Skip to content

feat(atlas-cloud): add GLM 5.2 to vendor catalog - #1755

Merged
kevincodex1 merged 1 commit into
Twigpine:mainfrom
kevincodex1:feat/atlas-glm-5.2
Jun 23, 2026
Merged

kevincodex1 merged 1 commit into
Twigpine:mainfrom
kevincodex1:feat/atlas-glm-5.2

Conversation

@kevincodex1

@kevincodex1 kevincodex1 commented Jun 23, 2026 •

Copy link
Copy Markdown
Member

Summary

  • what changed: Added zai-org/glm-5.2 ("GLM 5.2") to the Atlas Cloud vendor model list in src/integrations/vendors/atlas-cloud.ts with a 202,752-token context window, matching the existing GLM 5.1 / GLM 5 entries.
  • why it changed: GLM 5.2 is now available through the Atlas Cloud provider; registering it makes the model selectable through the OpenClaude Atlas Cloud integration.

Impact

  • user-facing impact: Users on the Atlas Cloud provider can now select "GLM 5.2" from the model picker.
  • developer/maintainer impact: One-line addition to the vendor's model array; no schema, auth, or default-model changes. Follows the existing zai-org/glm-* pattern.

Testing

  • bun run build
  • bun run smoke
  • focused tests: bun test ./src/integrations/vendors (if a vendor catalog test exists)
  • manual: /provider atlas → confirm GLM 5.2 appears in model list

Notes

  • provider/model path tested: Atlas Cloud / zai-org/glm-5.2 (catalog entry only; live API call not yet exercised).
  • screenshots attached (if UI changed): N/A (CLI-only, no UI screenshot).
  • follow-up work or known limitations: Context window set to 202,752 to match GLM 5.1; update if the upstream Atlas Cloud model card specifies a different limit. No alias/default-model changes made.

Summary by CodeRabbit

  • New Features
    • Added support for the zai-org/glm-5.2 model in Atlas Cloud integration.

Adds zai-org/glm-5.2 with the same 202,752 context window as GLM 5.1
so the model is selectable through the Atlas Cloud provider.

Co-Authored-By: OpenClaude <openclaude@gitlawb.com>
@coderabbitai

coderabbitai Bot commented Jun 23, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a4da32c2-3523-4bbc-a01b-f1cb3c906d4b

📥 Commits

Reviewing files that changed from the base of the PR and between 38b0e27 and d979822.

📒 Files selected for processing (1)
  • src/integrations/vendors/atlas-cloud.ts
📜 Recent review details
🧰 Additional context used
📓 Path-based instructions (9)
src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Use TypeScript with strict mode and ESM imports

Files:

  • src/integrations/vendors/atlas-cloud.ts
{src/integrations/**/*.ts,src/services/**/*.ts}

📄 CodeRabbit inference engine (AGENTS.md)

Test the exact provider/model path you changed when possible for provider modifications

Files:

  • src/integrations/vendors/atlas-cloud.ts
src/integrations/**/*.ts

📄 CodeRabbit inference engine (AGENTS.md)

Check existing provider implementations before adding a new pattern

Files:

  • src/integrations/vendors/atlas-cloud.ts
**/*.{ts,tsx,js,jsx,py,json,md}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Follow the existing code style in the touched files

Files:

  • src/integrations/vendors/atlas-cloud.ts
**/*.{ts,tsx,js,jsx,py}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Keep comments useful and concise

Files:

  • src/integrations/vendors/atlas-cloud.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Follow TypeScript strict mode and type safety practices by running typecheck before submitting

Files:

  • src/integrations/vendors/atlas-cloud.ts
**

⚙️ CodeRabbit configuration file

**: # AGENTS.md - AI Agent Coding Guide

This guide is for AI coding agents working in the OpenClaude repository. Read it before changing code, and also follow CONTRIBUTING.md for contributor policy, PR expectations, review follow-up, and project scope.

Project Snapshot

OpenClaude is a coding-agent CLI for cloud and local model providers. It supports OpenAI-compatible APIs, Anthropic, Gemini, DeepSeek, Ollama, MCP, local backends, slash commands, tools, agents, and a React/Ink terminal UI.

The installed CLI runs on Node.js >=22.0.0. Bun is used for source builds, scripts, dependency management, and tests.

Work Style

  • Keep changes focused on one problem.
  • Prefer existing patterns in the file or nearby module.
  • Avoid unrelated formatting, renames, dependency changes, or broad rewrites.
  • Add or update tests when behavior changes.
  • Update docs when setup, commands, provider behavior, or user-facing behavior changes.
  • For new features, larger refactors, dependencies, or runtime changes, follow the issue-first guidance in CONTRIBUTING.md.

Stack And Conventions

  • TypeScript with strict mode and ESM imports.
  • React + Ink for terminal UI.
  • Bun lockfile and Bun scripts for development workflows.
  • Node runtime for the built CLI.
  • Python exists for legacy/local-provider helper code. Do not add new Python code or expand Python-based features unless a maintainer explicitly approves that direction.

Common libraries and patterns:

  • chalk for terminal color.
  • commander for CLI argument parsing.
  • execa for child processes.
  • Existing service, provider, settings, permission, and UI patterns over new abstractions.

Repository Map

  • src/commands/ - slash and CLI command implementations.
  • src/components/ - React/Ink UI components.
  • src/services/ - API, MCP, OAuth, wiki, voice, and other service integrations.
  • src/tools/ - tool implementations.
  • src/utils/ - shared utilities.
  • `src/integration...

Files:

  • src/integrations/vendors/atlas-cloud.ts
**/*

⚙️ CodeRabbit configuration file

**/*: Apply the OpenClaude maintainer review rubric from AGENTS.md. Review the current diff, not stale discussion context. Separate real blockers from suggestions. Do not request changes for vague style churn. Treat approval as merge-ready from CodeRabbit's side, pending required human review and GitHub Checks. If checks are failing or unavailable, say so clearly instead of implying the PR is fully ready.

Files:

  • src/integrations/vendors/atlas-cloud.ts
{src/services/api/**,src/integrations/**,src/utils/model/**,src/utils/provider*.ts,src/commands/provider/**}

⚙️ CodeRabbit configuration file

{src/services/api/**,src/integrations/**,src/utils/model/**,src/utils/provider*.ts,src/commands/provider/**}: Review provider routing, model selection, env precedence, auth/token handling, OpenAI-compatible shims, retries, proxy behavior, and outbound HTTP behavior with high scrutiny. Block on silent default changes, hidden fallback expansion, credential reuse mistakes, hardcoded provider assumptions, or new network reach that is not intentional and documented.

Files:

  • src/integrations/vendors/atlas-cloud.ts
🔇 Additional comments (1)
src/integrations/vendors/atlas-cloud.ts (1)

58-58: 🎯 Functional Correctness

Please confirm provider-path validation for the new Atlas model before merge.

This catalog entry looks consistent with surrounding entries, but please verify zai-org/glm-5.2 on the Atlas provider path (model resolution + request execution) and confirm the contextWindow value against Atlas upstream docs/model card.

As per coding guidelines, “Test the exact provider/model path you changed when possible for provider modifications.” As per path instructions, “Review provider routing, model selection… with high scrutiny.”

Sources: Coding guidelines, Path instructions


📝 Walkthrough

Walkthrough

A single static model entry for zai-org/glm-5.2 is added to the Atlas Cloud vendor catalog in src/integrations/vendors/atlas-cloud.ts, specifying its apiName, label, and contextWindow.

Changes

Atlas Cloud Model Catalog

Layer / File(s) Summary
Add zai-org/glm-5.2 catalog entry
src/integrations/vendors/atlas-cloud.ts
Inserts one new static model entry for zai-org/glm-5.2 with its apiName, label, and contextWindow fields.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Gitlawb/openclaude#1585: Introduces the Atlas Cloud vendor and its initial static model catalog in the same file where this entry is added.

Suggested reviewers

  • jatmn
🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the actual change: adding GLM 5.2 to the Atlas Cloud vendor catalog, matching the diff scope.
Description check ✅ Passed The description comprehensively covers all required template sections with specific details about the change, impact, testing steps, and notes on context window assumptions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Risk Surface Disclosed ✅ Passed PR adds single model entry to static Atlas Cloud catalog; doesn't touch auth, provider routing, permissions, network behavior, or other sensitive risk surfaces requiring review callout.
No Hidden Policy Change ✅ Passed PR adds GLM 5.2 model to Atlas Cloud catalog only; no hidden policy changes to trust-model, routing-default, telemetry, or permission-policy detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kevincodex1
kevincodex1 merged commit c2467ee into Twigpine:main Jun 23, 2026
4 checks passed
@jatmn

jatmn commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@kevincodex1 please see..
#1754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants