Skip to content

fix: allow incorrect labels if placeholders are missing#5025

Merged
mergify[bot] merged 1 commit into
GitTools:mainfrom
robertcoltheart:bug/return-label-without-throwing
Jul 9, 2026
Merged

fix: allow incorrect labels if placeholders are missing#5025
mergify[bot] merged 1 commit into
GitTools:mainfrom
robertcoltheart:bug/return-label-without-throwing

Conversation

@robertcoltheart

@robertcoltheart robertcoltheart commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description

Avoids throwing when label placeholders are not found. This fixes a 6.x regression.

See #5021

Related Issue

Resolves #5026

Motivation and Context

Users reported that their existing config worked in 6.7 but threw exceptions in 6.8. The cause was bad config, but we should still support this behavior at least for 6.x. We can enforce good config from 7.x onwards.

How Has This Been Tested?

Added unit tests to validate old behavior.

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2026

Copy link
Copy Markdown

@robertcoltheart
robertcoltheart marked this pull request as ready for review July 8, 2026 10:31
@mergify

mergify Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

@arturcic
arturcic enabled auto-merge July 9, 2026 09:08
@arturcic

arturcic commented Jul 9, 2026

Copy link
Copy Markdown
Member

@Mergifyio refresh

@arturcic
arturcic disabled auto-merge July 9, 2026 09:08
@arturcic
arturcic enabled auto-merge July 9, 2026 09:08
@mergify

mergify Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

refresh

✅ Pull request refreshed

@arturcic

arturcic commented Jul 9, 2026

Copy link
Copy Markdown
Member

@Mergifyio queue

@mergify

mergify Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • Entered queue2026-07-09 09:10 UTC · Rule: default · triggered by @arturcic with the @mergifyio queue command
  • Checks skipped · PR is already up-to-date
  • Merged2026-07-09 09:10 UTC · at 6e9833f5c6f2ee21b2e22f6ff9a19288b305fc96 · merge

This pull request spent 28 seconds in the queue, including 5 seconds running CI.

Required conditions to merge
  • github-review-approved [🛡 GitHub repository ruleset rule main branch rule]
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = @github-actions/DotNet Format
    • check-neutral = @github-actions/DotNet Format
    • check-skipped = @github-actions/DotNet Format
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = @github-actions/Release
    • check-neutral = @github-actions/Release
    • check-skipped = @github-actions/Release
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = @github-actions/Build & Test (new-cli)
    • check-neutral = @github-actions/Build & Test (new-cli)
    • check-skipped = @github-actions/Build & Test (new-cli)
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = @github-actions/Build & Package / macos-26
    • check-neutral = @github-actions/Build & Package / macos-26
    • check-skipped = @github-actions/Build & Package / macos-26
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = @github-actions/Build & Package / ubuntu-24.04
    • check-neutral = @github-actions/Build & Package / ubuntu-24.04
    • check-skipped = @github-actions/Build & Package / ubuntu-24.04
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = @github-actions/Build & Package / windows-2025-vs2026
    • check-neutral = @github-actions/Build & Package / windows-2025-vs2026
    • check-skipped = @github-actions/Build & Package / windows-2025-vs2026
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = @github-actions/Test / macos-26 - net10.0
    • check-neutral = @github-actions/Test / macos-26 - net10.0
    • check-skipped = @github-actions/Test / macos-26 - net10.0
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = @github-actions/Test / macos-26 - net8.0
    • check-neutral = @github-actions/Test / macos-26 - net8.0
    • check-skipped = @github-actions/Test / macos-26 - net8.0
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = @github-actions/Test / macos-26 - net9.0
    • check-neutral = @github-actions/Test / macos-26 - net9.0
    • check-skipped = @github-actions/Test / macos-26 - net9.0
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = @github-actions/Test / ubuntu-24.04 - net10.0
    • check-neutral = @github-actions/Test / ubuntu-24.04 - net10.0
    • check-skipped = @github-actions/Test / ubuntu-24.04 - net10.0
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = @github-actions/Test / ubuntu-24.04 - net8.0
    • check-neutral = @github-actions/Test / ubuntu-24.04 - net8.0
    • check-skipped = @github-actions/Test / ubuntu-24.04 - net8.0
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = @github-actions/Test / ubuntu-24.04 - net9.0
    • check-neutral = @github-actions/Test / ubuntu-24.04 - net9.0
    • check-skipped = @github-actions/Test / ubuntu-24.04 - net9.0
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = @github-actions/Test / windows-2025-vs2026 - net10.0
    • check-neutral = @github-actions/Test / windows-2025-vs2026 - net10.0
    • check-skipped = @github-actions/Test / windows-2025-vs2026 - net10.0
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = @github-actions/Test / windows-2025-vs2026 - net8.0
    • check-neutral = @github-actions/Test / windows-2025-vs2026 - net8.0
    • check-skipped = @github-actions/Test / windows-2025-vs2026 - net8.0
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = @github-actions/Test / windows-2025-vs2026 - net9.0
    • check-neutral = @github-actions/Test / windows-2025-vs2026 - net9.0
    • check-skipped = @github-actions/Test / windows-2025-vs2026 - net9.0
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-neutral = Mergify Merge Protections
    • check-skipped = Mergify Merge Protections
    • check-success = Mergify Merge Protections
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = @sonarqubecloud/SonarCloud Code Analysis
    • check-neutral = @sonarqubecloud/SonarCloud Code Analysis
    • check-skipped = @sonarqubecloud/SonarCloud Code Analysis

@mergify mergify Bot added the queued label Jul 9, 2026
@mergify
mergify Bot merged commit b924ea7 into GitTools:main Jul 9, 2026
121 checks passed
@mergify mergify Bot removed the queued label Jul 9, 2026
@mergify

mergify Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Thank you @robertcoltheart for your contribution!

This was referenced Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ISSUE]: Incorrect label placeholders should not throw exception

3 participants