Fix SonarCloud issues S3400, S8264, S8677#4999
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Drop the workflow-level 'permissions: contents: read' and declare it on each job that previously inherited it (prepare, publish_flags, build, artifacts_windows_test, artifacts_linux_test); the remaining jobs already declared their own permissions. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Contributor
|
Thank you @arturcic for your contribution! |
Member
Author
|
🎉 This issue has been resolved in version 6.8.0 🎉 Your GitReleaseManager bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three accepted SonarCloud issues (reopened and addressed in code):
build/common/Addins/GitVersion/GitVersionRunner.cs) — extract the"GitVersion"literal returned by the requiredGetToolName()override into aprivate const string ToolName. (The method is a mandatedCake.Core.Tooling.Tool<T>override and can't be removed; this surfaces the value as a constant.).github/workflows/ci.yml) — move the workflow-levelpermissions: contents: readto the job level. The five jobs that previously inherited it (prepare,publish_flags,build,artifacts_windows_test,artifacts_linux_test) now declare it explicitly; the other five already had their own permissions blocks.src/mark-shipped.ps1) — replaceWrite-Hostwith the pipeline-compatibleWrite-Output.Validation
dotnet build ./build/CI.slnx— 0 errorsdotnet format ./build/CI.slnx --verify-no-changes— cleanactionlint— 0 findings repo-wide🤖 Generated with Claude Code