fix: resolve SonarCloud findings across the codebase and enforce style rules

.editorconfig

@@ -82,7 +82,7 @@ csharp_prefer_static_local_function = true:warning
 csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async:silent
 
 # Code-block preferences
-csharp_prefer_braces = when_multiline:none
+csharp_prefer_braces = true:error
 csharp_prefer_simple_using_statement = true:warning
 
 # Expression-level preferences
@@ -161,13 +161,16 @@ dotnet_style_qualification_for_event = false:error
 dotnet_diagnostic.IDE0009.severity = error
 
 # IDE0005: Using directive is unnecessary.
-dotnet_diagnostic.ide0005.severity = warning
+dotnet_diagnostic.IDE0005.severity = warning
+
+# IDE0305: Use collection expression for fluent 
+dotnet_diagnostic.IDE0305.severity = error
 
 # RCS1037: Remove trailing white-space.
-dotnet_diagnostic.rcs1037.severity = error
+dotnet_diagnostic.RCS1037.severity = error
 
 # RCS1036: Remove redundant empty line.
-dotnet_diagnostic.rcs1036.severity = error
+dotnet_diagnostic.RCS1036.severity = error
 
 dotnet_diagnostic.S2325.severity = none
 dotnet_diagnostic.S4136.severity = none
@@ -181,3 +184,9 @@ resharper_arrange_object_creation_when_type_not_evident_highlighting = none
 resharper_unused_auto_property_accessor_global_highlighting = none
 
 resharper_unused_method_return_value_global_highlighting = none
+
+# Test projects
+# Repeated string literals in tests (branch names, versions, config keys) are
+# intentionally inline for readability, so don't flag duplicate literals there.
+[**/*.Tests/**.cs]
+dotnet_diagnostic.S1192.severity = none

build/artifacts/Tasks/ArtifactsDotnetToolTest.cs

@@ -21,13 +21,19 @@ public override bool ShouldRun(BuildContext context)
     public override void Run(BuildContext context)
     {
         if (context.Version == null)
+        {
             return;
+        }
+
         var rootPrefix = string.Empty;
         var version = context.Version.NugetVersion;
 
         foreach (var dockerImage in context.Images)
         {
-            if (context.SkipImageTesting(dockerImage)) continue;
+            if (context.SkipImageTesting(dockerImage))
+            {
+                continue;
+            }
 
             var cmd = $"{rootPrefix}/scripts/test-global-tool.sh --version {version} --nugetPath {rootPrefix}/nuget --repoPath {rootPrefix}/repo";
 

build/artifacts/Tasks/ArtifactsExecutableTest.cs

@@ -30,7 +30,9 @@ public override void Run(BuildContext context)
     private static void PackageTest(BuildContextBase context, string packageToTest)
     {
         if (context.Version == null)
+        {
             return;
+        }
 
         var outputDirectory = Paths.Packages.Combine("test");
 

build/artifacts/Tasks/ArtifactsMsBuildCoreTest.cs

@@ -20,13 +20,19 @@ public override bool ShouldRun(BuildContext context)
     public override void Run(BuildContext context)
     {
         if (context.Version == null)
+        {
             return;
+        }
+
         var rootPrefix = string.Empty;
         var version = context.Version.NugetVersion;
 
         foreach (var dockerImage in context.Images)
         {
-            if (context.SkipImageTesting(dockerImage)) continue;
+            if (context.SkipImageTesting(dockerImage))
+            {
+                continue;
+            }
 
             var cmd = $"{rootPrefix}/scripts/test-msbuild-task.sh --version {version} --nugetPath {rootPrefix}/nuget --repoPath {rootPrefix}/repo/tests/integration --targetframework net{dockerImage.TargetFramework}";
 

build/artifacts/Tasks/ArtifactsMsBuildFullTest.cs

@@ -17,7 +17,10 @@ public override bool ShouldRun(BuildContext context)
     public override void Run(BuildContext context)
     {
         if (context.Version == null)
+        {
             return;
+        }
+
         var version = context.Version.NugetVersion;
         var fullSemVer = context.Version.GitVersion.FullSemVer;
 

build/artifacts/Tasks/ArtifactsNativeTest.cs

@@ -21,13 +21,19 @@ public override bool ShouldRun(BuildContext context)
     public override void Run(BuildContext context)
     {
         if (context.Version?.SemVersion == null)
+        {
             return;
+        }
+
         var version = context.Version.SemVersion.ToLower();
         var rootPrefix = string.Empty;
 
         foreach (var dockerImage in context.Images)
         {
-            if (context.SkipImageTesting(dockerImage)) continue;
+            if (context.SkipImageTesting(dockerImage))
+            {
+                continue;
+            }
 
             var runtime = "linux";
             if (dockerImage.Distro.StartsWith("alpine"))

build/artifacts/Tasks/ArtifactsPrepare.cs

@@ -21,7 +21,11 @@ public override void Run(BuildContext context)
     {
         foreach (var dockerImage in context.Images)
         {
-            if (context.SkipImageTesting(dockerImage)) continue;
+            if (context.SkipImageTesting(dockerImage))
+            {
+                continue;
+            }
+
             context.DockerPullImage(dockerImage);
         }
     }

build/build/Tasks/Package/PackageChocolatey.cs

@@ -24,16 +24,12 @@ public override void Run(BuildContext context)
         var artifactPath = context.MakeAbsolute(Paths.ArtifactsBinPortable).FullPath;
 
         var portableSettings = GetChocolateyPackSettings(context, "GitVersion.Portable");
-        portableSettings.Files = context.GetFiles(artifactPath + "/**/*.*")
-            .Select(file => new ChocolateyNuSpecContent { Source = file.FullPath, Target = file.FullPath.Replace(artifactPath, "") })
-            .ToArray();
+        portableSettings.Files = [.. context.GetFiles(artifactPath + "/**/*.*").Select(file => new ChocolateyNuSpecContent { Source = file.FullPath, Target = file.FullPath.Replace(artifactPath, "") })];
 
         context.ChocolateyPack(portableSettings);
 
         var metaPackageSettings = GetChocolateyPackSettings(context, "GitVersion");
-        metaPackageSettings.Files = context.GetFiles(artifactPath + "/**/*.txt")
-            .Select(file => new ChocolateyNuSpecContent { Source = file.FullPath, Target = file.FullPath.Replace(artifactPath, "") })
-            .ToArray();
+        metaPackageSettings.Files = [.. context.GetFiles(artifactPath + "/**/*.txt").Select(file => new ChocolateyNuSpecContent { Source = file.FullPath, Target = file.FullPath.Replace(artifactPath, "") })];
 
         metaPackageSettings.Dependencies =
         [

build/build/Tasks/Package/PackagePrepare.cs

@@ -33,7 +33,10 @@ private static void PackPrepareNative(BuildContext context)
             var outputPath = PackPrepareNative(context, runtime);
 
             // testing windows and macos artifacts, the linux is tested with docker
-            if (platform == PlatformFamily.Linux) continue;
+            if (platform == PlatformFamily.Linux)
+            {
+                continue;
+            }
 
             if (context.IsRunningOnAmd64() && runtime.EndsWith("x64") || context.IsRunningOnArm64() && runtime.EndsWith("arm64"))
             {

build/common/Addins/GitVersion/GitVersionRunner.cs

@@ -38,7 +38,11 @@ public GitVersion Run(GitVersionSettings settings)
         Run(settings, GetArguments(settings), new ProcessSettings { RedirectStandardOutput = true }, process =>
         {
             output = string.Join("\n", process.GetStandardOutput());
-            if (this._log.Verbosity >= Verbosity.Diagnostic) return;
+            if (this._log.Verbosity >= Verbosity.Diagnostic)
+            {
+                return;
+            }
+
             var regex = ParseErrorRegex();
             var errors = regex.Matches(output)
                 .SelectMany(match => new[] { match.Groups[1].Value, match.Groups[2].Value });
@@ -49,7 +53,9 @@ public GitVersion Run(GitVersionSettings settings)
         });
 
         if (!settings.OutputTypes.Contains(GitVersionOutput.Json))
+        {
             return new GitVersion();
+        }
 
         var jsonStartIndex = output.IndexOf('{');
         var jsonEndIndex = output.IndexOf('}');

build/common/Tasks/Default.cs

@@ -10,7 +10,10 @@ public override void Run(ICakeContext context)
     {
         var entryAssembly = Assembly.GetEntryAssembly();
         var tasks = entryAssembly?.FindAllDerivedTypes(typeof(IFrostingTask)).Where(x => !x.Name.Contains("Internal")).ToList();
-        if (tasks == null) return;
+        if (tasks == null)
+        {
+            return;
+        }
 
         var defaultTask = tasks.Find(x => x.Name.Contains(nameof(Default)));
         if (defaultTask != null && tasks.Remove(defaultTask))

build/common/Utilities/ContextExtensions.cs

@@ -19,7 +19,7 @@ public IEnumerable<string> ExecuteCommand(FilePath exe, string? args, DirectoryP
             }
 
             context.StartProcess(exe, processSettings, out var redirectedOutput);
-            return redirectedOutput.ToList();
+            return [.. redirectedOutput];
         }
 
         private IEnumerable<string> ExecGitCmd(string? cmd, DirectoryPath? workDir = null)
@@ -84,9 +84,20 @@ public bool IsEnabled(string envVar, bool nullOrEmptyAsEnabled = true)
 
         public string GetOS()
         {
-            if (context.IsRunningOnWindows()) return "Windows";
-            if (context.IsRunningOnLinux()) return "Linux";
-            if (context.IsRunningOnMacOs()) return "macOs";
+            if (context.IsRunningOnWindows())
+            {
+                return "Windows";
+            }
+
+            if (context.IsRunningOnLinux())
+            {
+                return "Linux";
+            }
+
+            if (context.IsRunningOnMacOs())
+            {
+                return "macOs";
+            }
 
             return string.Empty;
         }
@@ -138,7 +149,10 @@ public void EndGroup()
 
         public bool ShouldRun(bool criteria, string skipMessage)
         {
-            if (criteria) return true;
+            if (criteria)
+            {
+                return true;
+            }
 
             context.Information(skipMessage);
             return false;

build/common/Utilities/DockerContextExtensions.cs

@@ -42,7 +42,10 @@ public bool SkipImageTesting(DockerImage dockerImage)
 
         public void DockerBuildImage(DockerImage dockerImage)
         {
-            if (context.Version == null) return;
+            if (context.Version == null)
+            {
+                return;
+            }
 
             var (distro, targetFramework, arch, registry, _) = dockerImage;
 
@@ -65,7 +68,7 @@ public void DockerBuildImage(DockerImage dockerImage)
                 Rm = true,
                 Pull = true,
                 // NoCache = true,
-                Tag = tags.ToArray(),
+                Tag = [.. tags],
                 Platform = [$"linux/{suffix}"],
                 Output = ["type=docker,oci-mediatypes=true"],
                 File = workDir.CombineWithFilePath("Dockerfile").FullPath,
@@ -185,7 +188,11 @@ private IEnumerable<string> GetDockerTags(DockerImage dockerImage,
             var distro = dockerImage.Distro;
             var targetFramework = dockerImage.TargetFramework;
 
-            if (context.Version == null) return [];
+            if (context.Version == null)
+            {
+                return [];
+            }
+
             var tags = new List<string>
             {
                 $"{name}:{context.Version.Version}-{distro}-{targetFramework}",
@@ -209,7 +216,10 @@ private IEnumerable<string> GetDockerTags(DockerImage dockerImage,
                 }
             }
 
-            if (!arch.HasValue) return tags.Distinct();
+            if (!arch.HasValue)
+            {
+                return tags.Distinct();
+            }
 
             var suffix = arch.Value.ToSuffix();
             return tags.Select(x => $"{x}-{suffix}").Distinct();

build/common/Utilities/Extensions.cs

@@ -80,12 +80,22 @@ public bool IsEqualInvariant(string other) =>
     /// </summary>
     public static string EscapeProcessArgument(this string literalValue, bool alwaysQuote = false)
     {
-        if (string.IsNullOrEmpty(literalValue)) return "\"\"";
+        if (string.IsNullOrEmpty(literalValue))
+        {
+            return "\"\"";
+        }
 
         if (literalValue.AsSpan().IndexOfAny(CharsRequiringQuoting) == -1) // Happy path
         {
-            if (!alwaysQuote) return literalValue;
-            if (literalValue[^1] != '\\') return $"\"{literalValue}\"";
+            if (!alwaysQuote)
+            {
+                return literalValue;
+            }
+
+            if (literalValue[^1] != '\\')
+            {
+                return $"\"{literalValue}\"";
+            }
         }
 
         return BuildEscapedArgument(literalValue);
@@ -99,16 +109,23 @@ private static string BuildEscapedArgument(string s)
         while (true)
         {
             var relativeIndex = s.AsSpan(nextPosition).IndexOfAny(CharsRequiringEscaping);
-            if (relativeIndex == -1) break;
+            if (relativeIndex == -1)
+            {
+                break;
+            }
 
             var nextEscapeChar = nextPosition + relativeIndex;
             sb.Append(s, nextPosition, relativeIndex);
             nextPosition = nextEscapeChar + 1;
 
             if (s[nextEscapeChar] == '"')
+            {
                 sb.Append("\\\"");
+            }
             else
+            {
                 nextPosition = AppendEscapedBackslashes(sb, s, nextPosition);
+            }
         }
 
         return sb.Append(s, nextPosition, s.Length - nextPosition).Append('"').ToString();
@@ -123,7 +140,9 @@ private static int AppendEscapedBackslashes(StringBuilder sb, string s, int next
             nextPosition++;
         }
         if (nextPosition == s.Length || s[nextPosition] == '"')
+        {
             numBackslashes <<= 1;
+        }
 
         sb.Append('\\', numBackslashes);
         return nextPosition;

build/docker/Tasks/DockerTest.cs

@@ -23,7 +23,11 @@ public override void Run(BuildContext context)
     {
         foreach (var dockerImage in context.Images)
         {
-            if (context.SkipImageTesting(dockerImage)) continue;
+            if (context.SkipImageTesting(dockerImage))
+            {
+                continue;
+            }
+
             context.DockerTestImage(dockerImage);
         }
     }

build/docs/Tasks/PublishDocs.cs

@@ -88,12 +88,18 @@ private static void PublishDocumentation(BuildContext context)
         context.EnsureDirectoryExists(schemaTargetDir);
         context.CopyDirectory(Paths.Schemas, schemaTargetDir);
 
-        if (!context.GitHasUncommitedChanges(publishFolder)) return;
+        if (!context.GitHasUncommitedChanges(publishFolder))
+        {
+            return;
+        }
 
         context.Information("Stage all changes...");
         context.GitAddAll(publishFolder);
 
-        if (!context.GitHasStagedChanges(publishFolder)) return;
+        if (!context.GitHasStagedChanges(publishFolder))
+        {
+            return;
+        }
 
         context.Information("Commit all changes...");
         context.GitCommit(