Skip to content

Fix computing next Depth from parentIteration#4964

Merged
mergify[bot] merged 1 commit into
GitTools:mainfrom
jnyrup:patch-1
Jun 9, 2026
Merged

Fix computing next Depth from parentIteration#4964
mergify[bot] merged 1 commit into
GitTools:mainfrom
jnyrup:patch-1

Conversation

@jnyrup

@jnyrup jnyrup commented Jun 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Parenthesize ?? as + binds stronger.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@asbjornu

asbjornu commented Jun 7, 2026

Copy link
Copy Markdown
Member

The code change looks good, but since no tests broke from the change, it's obvious we need at least one test to ensure this doesn't regress in the future. Can you please add one? :)

asbjornu
asbjornu approved these changes Jun 8, 2026
View reviewed changes

@asbjornu asbjornu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arturcic

arturcic commented Jun 9, 2026

Copy link
Copy Markdown
Member

@jnyrup please fix the synarcloud issue

@arturcic

arturcic commented Jun 9, 2026

Copy link
Copy Markdown
Member

@jnyrup please rebase onto main branch

@jnyrup
Fix computing next Depth from parentIteration
84244af 
Parenthesize `??` as `+` binds stronger
@sonarqubecloud

sonarqubecloud Bot commented Jun 9, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@arturcic
arturcic enabled auto-merge June 9, 2026 08:15
@arturcic

arturcic commented Jun 9, 2026

Copy link
Copy Markdown
Member

@Mergifyio queue

@mergify

mergify Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-06-09 10:19 UTC · Rule: default
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged — 2026-06-09 10:20 UTC · at 84244af020ef341ced815303ac65132d98b36bf3 · merge

This pull request spent 17 seconds in the queue, including 2 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub repository ruleset rule main branch rule]
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = DotNet Format
    • check-neutral = DotNet Format
    • check-skipped = DotNet Format
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = Release
    • check-neutral = Release
    • check-skipped = Release
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = Build & Test (new-cli)
    • check-neutral = Build & Test (new-cli)
    • check-skipped = Build & Test (new-cli)
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = Build & Package / macos-26
    • check-neutral = Build & Package / macos-26
    • check-skipped = Build & Package / macos-26
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = Build & Package / ubuntu-24.04
    • check-neutral = Build & Package / ubuntu-24.04
    • check-skipped = Build & Package / ubuntu-24.04
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = Build & Package / windows-2025-vs2026
    • check-neutral = Build & Package / windows-2025-vs2026
    • check-skipped = Build & Package / windows-2025-vs2026
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = Test / macos-26 - net10.0
    • check-neutral = Test / macos-26 - net10.0
    • check-skipped = Test / macos-26 - net10.0
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = Test / macos-26 - net8.0
    • check-neutral = Test / macos-26 - net8.0
    • check-skipped = Test / macos-26 - net8.0
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = Test / macos-26 - net9.0
    • check-neutral = Test / macos-26 - net9.0
    • check-skipped = Test / macos-26 - net9.0
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = Test / ubuntu-24.04 - net10.0
    • check-neutral = Test / ubuntu-24.04 - net10.0
    • check-skipped = Test / ubuntu-24.04 - net10.0
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = Test / ubuntu-24.04 - net8.0
    • check-neutral = Test / ubuntu-24.04 - net8.0
    • check-skipped = Test / ubuntu-24.04 - net8.0
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = Test / ubuntu-24.04 - net9.0
    • check-neutral = Test / ubuntu-24.04 - net9.0
    • check-skipped = Test / ubuntu-24.04 - net9.0
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = Test / windows-2025-vs2026 - net10.0
    • check-neutral = Test / windows-2025-vs2026 - net10.0
    • check-skipped = Test / windows-2025-vs2026 - net10.0
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = Test / windows-2025-vs2026 - net8.0
    • check-neutral = Test / windows-2025-vs2026 - net8.0
    • check-skipped = Test / windows-2025-vs2026 - net8.0
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = Test / windows-2025-vs2026 - net9.0
    • check-neutral = Test / windows-2025-vs2026 - net9.0
    • check-skipped = Test / windows-2025-vs2026 - net9.0
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-neutral = Mergify Merge Protections
    • check-skipped = Mergify Merge Protections
    • check-success = Mergify Merge Protections
  • any of [🛡 GitHub repository ruleset rule main branch rule]:
    • check-success = SonarCloud Code Analysis
    • check-neutral = SonarCloud Code Analysis
    • check-skipped = SonarCloud Code Analysis

@mergify mergify Bot added the queued label Jun 9, 2026
@mergify
mergify Bot merged commit fb6056c into GitTools:main Jun 9, 2026
120 checks passed
@mergify mergify Bot removed the queued label Jun 9, 2026
@mergify

mergify Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Thank you @jnyrup for your contribution!

@arturcic arturcic added this to the 6.x milestone Jun 10, 2026
@arturcic arturcic modified the milestones: 6.x, 6.8.0 Jun 30, 2026
@arturcic

arturcic commented Jun 30, 2026

Copy link
Copy Markdown
Member

🎉 This issue has been resolved in version 6.8.0 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

@gittools-bot gittools-bot mentioned this pull request Jul 1, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asbjornu asbjornu asbjornu approved these changes
@arturcic arturcic arturcic approved these changes

Assignees

No one assigned

Labels

improvement

Projects

None yet

Milestone

6.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jnyrup @asbjornu @arturcic