Skip to content

fix: include actual key name in /overrideconfig unsupported key error message #4874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arturcic merged 2 commits into from
Mar 16, 2026
Merged

fix: include actual key name in /overrideconfig unsupported key error message #4874

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dde6e7
fix: include actual key name in /overrideconfig unsupported key error…
Copilot Mar 16, 2026
911c254
use lowered optionKey instead of non-lowered
denisbredikhin Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/GitVersion.App.Tests/ArgumentParserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ private static IEnumerable<TestCaseData> OverrideconfigWithInvalidOptionTestData
};
yield return new TestCaseData("unknown-option=25")
{
ExpectedResult = "Could not parse /overrideconfig option: unknown-option=25. Unsupported 'key'."
ExpectedResult = "Could not parse /overrideconfig option: unknown-option=25. Unsupported key 'unknown-option'."
};
}

Expand Down
2 changes: 1 addition & 1 deletion src/GitVersion.App/ArgumentParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ private static void ParseOverrideConfig(Arguments arguments, IReadOnlyCollection
var optionKey = keyAndValue[0].ToLowerInvariant();
if (!OverrideConfigurationOptionParser.SupportedProperties.Contains(optionKey))
{
throw new WarningException($"Could not parse /overrideconfig option: {keyValueOption}. Unsupported 'key'.");
throw new WarningException($"Could not parse /overrideconfig option: {keyValueOption}. Unsupported key '{keyAndValue[0]}'.");
Comment thread
denisbredikhin marked this conversation as resolved.
Outdated
}
parser.SetValue(optionKey, keyAndValue[1]);
}
Expand Down
Loading